feat: adding job streaming support #812
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LennartKleymann
force-pushed
the
661-adding-job-streaming-support
branch
from
9f1c627 to
3afef6f
Compare
|
thanks for the PRs Lennart! i will take a look at these next week! |
nloding
added
feature
waiting-for-camunda
nloding
approved these changes
Oct 15, 2025
ChrisKujawa
reviewed
Oct 18, 2025
Comment on lines
+172
to
+173
| var jobCount = maxJobsActive - currentJobs; | ||
| activateJobsRequest.MaxJobsToActivate = jobCount; |
There was a problem hiding this comment.
❓ I think this is to set the limit for the activation request we use during polling, right? I think the calculation is wrong here? Because we missed updating the currentJobs as we just received a job.
There was a problem hiding this comment.
Actually looking at the code I think it is not necessary to change the request here or calculate this. I think we can remove this
dimasm61
reviewed
Oct 20, 2025
| var jobCount = maxJobsActive - currentJobs; | ||
| activateJobsRequest.MaxJobsToActivate = jobCount; | ||
|
|
||
| logger?.LogInformation( |
dimasm61
reviewed
Oct 20, 2025
| if (!await stream.ResponseStream.MoveNext(cancellationToken)) | ||
| { | ||
| logger?.LogDebug("Job stream MoveNext returned false; retrying shortly"); | ||
| await Task.Delay(50, cancellationToken); |
There was a problem hiding this comment.
Use a constant value... there are better options)
These delays may not be not correct for hiload.
In my code (local fork) I'v moved these values to the app settings. In this line I use 10ms, and on line 156 I use 100ms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #661
inspired by @dimasm61
- Opens a long‑lived stream; jobs are pushed without polling.
- Backfilling threshold at 60% of MaxJobsActive to avoid over‑buffering.