Skip to content

Conversation

tom-wegener
Copy link

@tom-wegener tom-wegener commented Jul 24, 2025

Closes carbon-design-system/carbon-components-angular#

In preparation of the angular update we need to update storybook.
This PR updates storybook to v9 (latest), removes react dependencies and accommodates the changes of storybook.

Closes #3068

Changelog

Changed

  • updated storybook to v9
  • fixed some storybook erors
  • added storybook linter to eslint

Removed

  • react dependencies

@tom-wegener tom-wegener requested a review from a team as a code owner July 24, 2025 08:26
Copy link

netlify bot commented Jul 24, 2025

Deploy Preview for carbon-angular-next ready!

Name Link
🔨 Latest commit 7bd0c07
🔍 Latest deploy log https://app.netlify.com/projects/carbon-angular-next/deploys/688b65a821ffb5000823f52c
😎 Deploy Preview https://deploy-preview-3162--carbon-angular-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 24, 2025

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 7bd0c07
🔍 Latest deploy log https://app.netlify.com/projects/carbon-components-angular/deploys/688b65a8d99fc200085297fa
😎 Deploy Preview https://deploy-preview-3162--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tom-wegener tom-wegener marked this pull request as draft July 31, 2025 09:15
@tom-wegener tom-wegener force-pushed the update-storybook branch 2 times, most recently from 2b800be to 92d50e5 Compare July 31, 2025 12:01
@tom-wegener tom-wegener marked this pull request as ready for review July 31, 2025 12:59
@tom-wegener
Copy link
Author

I'm sorry for the spam, I had some proxy set and because of that the github action (and other people) couldn't use the package-lock.json and I had to try some things to figure out that it was the problem. I hope it works now (github action seems fine).

The changeset seems massive but most of it is:

  • loosing react from package.json and the changes to package-lock.json
  • updating storybook and the following changes to the package-lock.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant