Skip to content

fix(multi-select): address a11y issues #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Aug 17, 2025

Supports #2172

Related #2186

This attempts to fix a11y issues reported by the IBM Accessibility Checker extension.

The default (non-filterable) MultiSelect has different semantics than the filterable variant.

This PR currently contains a fix for the nested buttons by making them siblings. Review with whitespace-hidden.

This PR is not complete:

  • Non-filterable uses a button with combobox role, e.g.,:
<button type="button" aria-describedby="multiselect-helper-text-id-«r2e»" aria-activedescendant="" aria-controls="downshift-«r2g»-menu" aria-expanded="false" aria-haspopup="listbox" aria-labelledby="downshift-«r2g»-label" id="downshift-«r2g»-toggle-button" role="combobox" tabindex="0" />
<input aria-activedescendant="" aria-autocomplete="list" aria-expanded="false" autocomplete="off" id="carbon-multiselect-example-3-input" role="combobox" aria-describedby="filterablemultiselect-helper-text-id-«r4»" aria-haspopup="listbox" value="">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant