Fix Windows build when targeting the MSVC ABI #26
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interact with precompiled libraries built with Visual Studio, like a proprietary middleware
|
Just quickly want to let you know that I'm not ignoring this PR, I'm just very busy with real-life work at the moment and testing/verifying these changes against an upstream MSVC build will take a bit of effort because I don't have an MSVC dev environment set up on my PC. Things will clear up in about two weeks so I hope I can get back to this by then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Windows build when targeting the MSVC ABI, which you want if you interact with precompiled libraries built with Visual Studio, like a proprietary middleware.