Skip to content

GH Actions: Backported fixes for macOS (3.21) #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2024
Merged

GH Actions: Backported fixes for macOS (3.21) #5500

merged 3 commits into from
May 7, 2024

Conversation

olehermanse
Copy link
Member

No description provided.

craigcomstock and others added 2 commits May 6, 2024 19:54
@craigcomstock @olehermanse
GH Actions macOS: Fixed installation and PATH for libtool and autoconf
f26421a 
(cherry picked from commit a952695)
@larsewi @olehermanse
GH Actions macOS: Use brew --prefix to locate LMDB, OpenSSL, and pcre
c384719 
Ticket: None
Changelog: None
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
(cherry picked from commit 2f66397)
@olehermanse olehermanse mentioned this pull request May 6, 2024
Merged
@olehermanse
GH Action macOS: Reverted to pcre
1315fe3 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse olehermanse merged commit 9c13ec9 into cfengine:3.21.x May 7, 2024
11 checks passed
@larsewi
Copy link
Contributor

larsewi commented May 7, 2024

@olehermanse, can you do the same for 3.18?

@larsewi larsewi mentioned this pull request May 7, 2024
Closed
@olehermanse
Copy link
Member Author

@larsewi probably won't get to it today, maybe tomorrow 😅

FYI, it looks like you were upgrading libntech in your PR - I was not. I only fixed GH Actions.

@olehermanse olehermanse deleted the 3.21.x_macos branch May 7, 2024 18:56
@olehermanse olehermanse added the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label May 7, 2024
@craigcomstock craigcomstock mentioned this pull request May 8, 2024
Closed
@olehermanse
Copy link
Member Author

3.18:
#5505

@olehermanse olehermanse removed the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label May 10, 2024
@olehermanse
Copy link
Member Author

@craigcomstock @larsewi It would've been a lot more efficient if you just did the cherry-pick and got it merged, rather than asking me to do it, waiting, opening a PR, closing it again, etc.

@olehermanse
Copy link
Member Author

@olehermanse, can you do the same for 3.18?

3.18 done and merged; #5505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsewi larsewi larsewi approved these changes

@nickanderson nickanderson Awaiting requested review from nickanderson

@craigcomstock craigcomstock Awaiting requested review from craigcomstock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olehermanse @larsewi @craigcomstock