ENT-12766: Fixed ODR violations in ASAN Unit Tests (3.24.x) #5785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: ENT-12766 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> (cherry picked from commit 88e6052)
larsewi
force-pushed
the
violations-3.24.x
branch
4 times, most recently
from
9fae517 to
9b978c3
Compare
| @@ -188,6 +188,7 @@ if MACOSX | |||
| XFAIL_TESTS = set_domainname_test | |||
| XFAIL_TESTS += process_test | |||
| XFAIL_TESTS += mon_processes_test | |||
| XFAIL_TESTS += rlist_test | |||
There was a problem hiding this comment.
can we put a reference to the ticket here? would be nice if we already did that previously so we have context on WHY these tests are allowed to fail.
They are not needed and they cause ODR violations to be triggered in address sanitizer. Ticket: ENT-12766 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
For some reason rlist_test fails in macOS unit tests. The test seems to `abort()` while it should trigger an assert so that `expect_assert_failure()` can catch it. For some reason this is not happening anymore. ``` rlist.c:135: Programming Error: Internal error: Rval contains type f instead of expected scalar ``` I created a ticket (CFE-4473) to follow-up on this. Ticket: None Changelog: None Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> (cherry picked from commit e8efa14)
larsewi
force-pushed
the
violations-3.24.x
branch
from
9b978c3 to
9785566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-12766
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech
(cherry picked from commit 88e6052)
Back-ported from #5656