Do not merge: Prove that ENT-12953 is caused by ENT-12751

libpromises/processes_select.c

@@ -778,17 +778,6 @@ static bool SplitProcLine(const char *line,
 
       Take these two examples:
 
-Windows:
-    User field can contain spaces. E.g.:
-
-    USER                   PID %CPU %MEM      VSZ       RSS TTY STAT START  TIME COMMAND
-    NETWORK SERVICE        540  0.0  0.3     5092     11180 ?   ?    Apr28 00:00 C:\\Windows\\system32\\svchost.exe -k RPCSS -p
-    etc.
-
-    There is really no good way to do this with the current parsing logic. We
-    know that the next field will be a PID, so we can parse until we find a
-    number.
-
 AIX:
     USER      PID     PPID     PGID  %CPU  %MEM   VSZ NI S    STIME        TIME COMMAND
     root        1        0        0   0.0   0.0   784 20 A   Nov 28    00:00:00 /etc/init
@@ -902,7 +891,6 @@ Solaris 9:
         bool cmd = (strcmp(names[field], "CMD") == 0 ||
                     strcmp(names[field], "COMMAND") == 0);
         bool stime = !cmd && (strcmp(names[field], "STIME") == 0);
-        bool is_user_field = StringEqual(names[field], "USER");
 
         // Equal boolean results, either both must be true, or both must be
         // false. IOW we must either both be at the last field, and it must be
@@ -993,41 +981,6 @@ Solaris 9:
                 last++;
             }
         }
-        else if (is_user_field)
-        {
-            bool done = false;
-            while (!done)
-            {
-                while (line[last] != '\0' && !isspace(line[last]))
-                {
-                    last++;
-                }
-
-                /* On windows the USER field can contain spaces. We know that
-                 * the next field will be PID. Hence, we seek past the spaces
-                 * to see if the next thing is a number. If this is not the
-                 * case, we assume it is still the USER field. This is not
-                 * bulletproof. However, this parser never was. */
-                int seek_past = last;
-                while (line[seek_past] != '\0' && isspace(line[seek_past]))
-                {
-                    seek_past++;
-                }
-
-                if (line[seek_past] == '\0')
-                {
-                    done = true;
-                }
-                else if (isdigit(line[seek_past]))
-                {
-                    done = true;
-                }
-                else
-                {
-                    last = seek_past;
-                }
-            }
-        }
         else
         {
             // Generic fields

tests/unit/Makefile.am

@@ -86,7 +86,6 @@ libdb_la_LIBADD = ../../libntech/libutils/libutils.la
 libdb_la_CFLAGS = $(AM_CFLAGS)
 
 check_PROGRAMS = \
-	processes_select_test \
 	arg_split_test \
 	assoc_test \
 	getopt_test \
@@ -188,10 +187,6 @@ if HPUX
 XFAIL_TESTS = mon_load_test # Redmine #3569
 endif
 
-
-processes_select_test_SOURCES = processes_select_test.c
-processes_select_test_LDADD = libtest.la ../../libpromises/libpromises.la
-
 #
 # OS X uses real system calls instead of our stubs unless this option is used
 #