CFE-3866: Added test that set_variable_values_ini does not error when keys are not present in promised section #2141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not present in promised section Ticket: CFE-3866 Changelog: None
nickanderson
force-pushed
the
CFE-3866_no-error-when-set_variable_values_ini-section-keys-not-present/master
branch
from
59a650c to
28d6187
Compare
Previously set_variable_values_ini would try to resolve field_edits before first ensuring that the section of the ini being promised was resolved. This results in errors when there are no fields to edit. This change uses bundle scoped classes to guard field_edits from actuating until after the promise ensuring the section itself exists has been reached, effectively preventing the errors from being emitted. Ticket: CFE-3867 Changelog: Commit
section can include characters that are not valid classes are canonified automatically on definition, but we gotta do that for checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.