Skip to content

Internal: Align table headers and data to the left for stats page - refs BT#21957 #5794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Internal: Align table headers and data to the left for stats page - refs BT#21957 #5794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions assets/css/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,12 @@ form .field {
@apply mt-4;
}

.stats_table {
thead th {
@apply bg-gray-20 text-gray-90 font-semibold text-left px-4 py-3 border-b border-gray-30;
}
}

//@import 'primevue-md-light-indigo/theme.css';
//@import '~primevue/resources/primevue.min.css';
//@import '~primeflex/primeflex.css';
Expand Down
2 changes: 1 addition & 1 deletion public/main/admin/statistics/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@
);

$scoreDisplay = ScoreDisplay::instance();
$table = new HTML_Table(['class' => 'table table-hover table-striped data_table']);
$table = new HTML_Table(['class' => 'table table-hover table-striped data_table stats_table']);
$headers = [
get_lang('Name'),
get_lang('Count'),
Expand Down
6 changes: 3 additions & 3 deletions public/main/inc/lib/statistics.lib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ public static function printStats(
$isFileSize = false
) {
$total = 0;
$content = '<table class="table table-hover table-striped data_table" cellspacing="0" cellpadding="3" width="90%">
$content = '<table class="table table-hover table-striped data_table stats_table" cellspacing="0" cellpadding="3" width="90%">
<thead><tr><th colspan="'.($showTotal ? '4' : '3').'">'.$title.'</th></tr></thead><tbody>';
$i = 0;
foreach ($stats as $subtitle => $number) {
Expand Down Expand Up @@ -1299,7 +1299,7 @@ public static function buildJsChartData($all, $chartName)
}

$scoreDisplay = ScoreDisplay::instance();
$table = new HTML_Table(['class' => 'data_table']);
$table = new HTML_Table(['class' => 'data_table stats_table']);
$headers = [
get_lang('Name'),
get_lang('Count'),
Expand Down Expand Up @@ -1382,7 +1382,7 @@ public static function printLoginsByDate()
);
}

$table = new HTML_Table(['class' => 'data_table']);
$table = new HTML_Table(['class' => 'data_table stats_table']);
$table->setHeaderContents(0, 0, get_lang('Username'));
$table->setHeaderContents(0, 1, get_lang('First name'));
$table->setHeaderContents(0, 2, get_lang('Last name'));
Expand Down
Loading