Skip to content

Course: Fix unique answer IDs in quiz export to prevent Moodle import errors - refs BT#21977 #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

Course: Fix unique answer IDs in quiz export to prevent Moodle import errors - refs BT#21977 #6398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions main/inc/lib/moodleexport/QuizExport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,13 +209,16 @@ private function mapQuestionType(string $quizType): string
*/
private function getAnswersForQuestion(int $questionId): array
{
static $globalCounter = 0;
$answers = [];
$quizResources = $this->course->resources[RESOURCE_QUIZQUESTION] ?? [];

foreach ($quizResources as $questionData) {
if ($questionData->source_id == $questionId) {
foreach ($questionData->answers as $answer) {
$globalCounter++;
$answers[] = [
'id' => $questionId * 1000 + $globalCounter,
'text' => $answer['answer'],
'fraction' => $answer['correct'] == '1' ? 100 : 0,
'feedback' => $answer['comment'],
Expand Down Expand Up @@ -316,16 +319,18 @@ private function createQuizXml(array $quizData, string $destinationDir): void

// Add question instances
$xmlContent .= ' <question_instances>'.PHP_EOL;
$slotIndex = 1;
foreach ($quizData['questions'] as $question) {
$xmlContent .= ' <question_instance id="'.$question['id'].'">'.PHP_EOL;
$xmlContent .= ' <slot>'.$question['id'].'</slot>'.PHP_EOL;
$xmlContent .= ' <slot>'.$slotIndex.'</slot>'.PHP_EOL;
$xmlContent .= ' <page>1</page>'.PHP_EOL;
$xmlContent .= ' <requireprevious>0</requireprevious>'.PHP_EOL;
$xmlContent .= ' <questionid>'.$question['id'].'</questionid>'.PHP_EOL;
$xmlContent .= ' <questioncategoryid>'.$question['questioncategoryid'].'</questioncategoryid>'.PHP_EOL;
$xmlContent .= ' <includingsubcategories>$@NULL@$</includingsubcategories>'.PHP_EOL;
$xmlContent .= ' <maxmark>'.$question['maxmark'].'</maxmark>'.PHP_EOL;
$xmlContent .= ' </question_instance>'.PHP_EOL;
$slotIndex++;
}
$xmlContent .= ' </question_instances>'.PHP_EOL;

Expand Down Expand Up @@ -417,8 +422,10 @@ private function exportTrueFalseQuestion(array $question): string
}
$xmlContent .= ' </answers>'.PHP_EOL;
$xmlContent .= ' <truefalse id="'.($question['id'] ?? '0').'">'.PHP_EOL;
$xmlContent .= ' <trueanswer>'.($question['answers'][0]['id'] ?? '0').'</trueanswer>'.PHP_EOL;
$xmlContent .= ' <falseanswer>'.($question['answers'][1]['id'] ?? '0').'</falseanswer>'.PHP_EOL;
$trueId = $question['answers'][0]['id'] ?? 0;
$falseId = $question['answers'][1]['id'] ?? 0;
$xmlContent .= ' <trueanswer>'.$trueId.'</trueanswer>'.PHP_EOL;
$xmlContent .= ' <falseanswer>'.$falseId.'</falseanswer>'.PHP_EOL;
$xmlContent .= ' </truefalse>'.PHP_EOL;
$xmlContent .= ' </plugin_qtype_truefalse_question>'.PHP_EOL;

Expand Down
Loading