-
Notifications
You must be signed in to change notification settings - Fork 54
Charm++ support for reconverse #3910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ritvikrao
wants to merge
65
commits into
main
Choose a base branch
from
reconverse-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…charm into reconverse-suport
…y to linking path
This reverts commit 3b9e082.
Clean up inconsistent whitespace in ckcheckpoint.C, cklocation.C, ckrdma.h, init.C, partitioning_strategies.C, spanningTree.C, and TopoManager.C for better code consistency. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates the reconverse communication layer in Charm++, a future replacement for Converse that is more sustainable, more lightweight (fewer lines of code), and incorporates LCI (github.com/uiuc-hpc/lci).
Installing and running on Delta
In the charm top-level directory,
In user program, change Makefile to point to charm, for example
When submitting jobs (sbatch or salloc), export the following
Use a larger process width than you would with old converse (i find that 2 or 4 procs per socket gives me the best times on reconverse, vs. 8 in old converse)
Make sure to
+pemap
if you are using all/almost all cores. If you do not do this then if 2 PEs are mapped to the same PU, your job will abort without explanation (except if you do bullet point c below)Setcpuaffinity isn’t implemented yet in reconverse so you need to provide a manual pemap
Run srun jobs with
--unbuffered
to force prints before aborting (to help with debugging)Delta documentation shows layout of cores wrt numa domains https://docs.ncsa.illinois.edu/systems/delta/en/latest/user_guide/architecture.html
Note 0:
You can let charm use your local copy of reconverse by
Note 1:
Instead of specifying
export LCI_ATTR_BACKEND=ofi
every time you run the program, you could also do