fix: Remove Exif with non-fatal errors from images #7280
Conversation
iequidoo
force-pushed
the
iequidoo/exif-continue_on_error
branch
from
15ed531 to
966cd48
Compare
| let exif = exif::Reader::new() | ||
| .continue_on_error(true) | ||
| .read_from_container(&mut bufreader) | ||
| .or_else(|e| e.distill_partial_result(|_errors| {})) |
There was a problem hiding this comment.
would it make sense to log something in this case?
There was a problem hiding this comment.
We only use the orientation field from Exif, so errors here are probably irrelevant, but we can log them if we pass Context to this function, i'm just unsure it's worth doing that
There was a problem hiding this comment.
what is the change in this file?
There was a problem hiding this comment.
I added a comment to test_recode_image_1(), i corrupted Exif in this file to test that it's still detected and removed by recoding the file. I could add another file instead, but we already have several JPEG test files, others contain Exif without invalid fields, so parsing correct Exif is still covered by other tests
There was a problem hiding this comment.
I'd at least rename this file to have "corrupted_exif" or so on the name.
There was a problem hiding this comment.
And I think it's better to add a new test for this without modifying existing one with no broken exif.
There was a problem hiding this comment.
Finally decided to add another test using another file not to affect existing tests
iequidoo
force-pushed
the
iequidoo/exif-continue_on_error
branch
from
966cd48 to
67360bd
Compare
NB: This still doesn't help with detecting Exif in PNGs unfortunately.
iequidoo
force-pushed
the
iequidoo/exif-continue_on_error
branch
from
67360bd to
a5829cd
Compare
3 participants
No description provided.