Do not fail to receive_imf call accepted/ended messages referring to non-call Message-ID #7292
Conversation
link2xt
force-pushed
the
link2xt/non-call-in-reply-to
branch
2 times, most recently
from
8339571 to
87efbb7
Compare
link2xt
force-pushed
the
link2xt/non-call-in-reply-to
branch
from
87efbb7 to
a123432
Compare
|
First two commits have a test. Third does not because it is only to prevent IMAP loop from getting stuck in a loop if there is another unexpected bug. |
src/imap.rs
Outdated
| .await? | ||
| .await | ||
| { | ||
| Err(err) => { |
There was a problem hiding this comment.
This shouldn't happen at all normally, but only if there are I/O errors or the context itself is in some broken state. But such a fix is fine as a temporary solution
There was a problem hiding this comment.
I have removed third commit that ignores errors, will merge without it.
In this case the problem was that ensure error was bubbled up, hopefully there are no such similar problems. At least we will be able to debug them if they are not ignored.
| } | ||
|
|
||
| if mime_parser.is_call() { | ||
| if is_partial_download.is_none() && mime_parser.is_call() { |
There was a problem hiding this comment.
So, instead of this i'd suggest to only parse minimum set of headers in mimeparser for partial downloads. Otherwise it's hard (not possible in practice) to always check this is_partial_download for all kinds of functionality we have like calls, webxdcs, etc.
link2xt
force-pushed
the
link2xt/non-call-in-reply-to
branch
from
a123432 to
04fa37e
Compare
… non-call Message-ID In-Reply-To may refer to non-call message as we do not control the sender. It may also happen that call message was received by older version and processed as text, in which case correct In-Reply-To appears to be referring to the text message.
Any control information from the message should only be downloaded when the message is fully downloaded to avoid processing it twice. Besides, "partial" messages may actually be full messages with an error that are only processed as partial to add a message bubble allowing to download the message later.
link2xt
force-pushed
the
link2xt/non-call-in-reply-to
branch
from
04fa37e to
aa8a242
Compare
2 participants
Closes #7290