page-xfer: use fixed-size 64-bit type for nr_pages #2757
+60
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avagin
reviewed
Sep 25, 2025
rst0git
force-pushed
the
page-xfer-nr-pages
branch
from
8d54e0f to
33afd66
Compare
rst0git
changed the title
The size of `unsigned long` is not guaranteed across platforms which leads to build errors on armv7. Using `uint64_t` allows us to address this issue as it is always 64-bit. Fixes: checkpoint-restore#2756 Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
rst0git
force-pushed
the
page-xfer-nr-pages
branch
from
33afd66 to
32c5bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ARMv7
unsigned longis 32-bit whileu64is 64-bit. This caused multiple build failures:u64 *topage_pipe_read(), which expectsunsigned long *.%lxto print au64field, which triggers-Wformaterrors under-Werror.This patch resolves the build failures on armv7 while preserving correct semantics for 64-bit builds.
Fixes: #2756