Integrate bant BUILD dependency cleaner into CI
#2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
changed the title
hzeller
changed the title
... and fix some superfluous dependencies it found. Fixes #655
hzeller
changed the title
bant BUILD dependency cleaner into CI
fangism
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the http://bant.build/ tool in the CI checking, for missing and superfluous dependencies in BUILD files and emitting a
buildozer1 script to fix (The CI just checks the cleanness, the user has to run the buildozer commands and update the PR).Fixes #655
(There is an open feature request issue on bazel for such a tool, but none exists as of now (bazelbuild/bazel#6871).
The
bantutility generally helps to explore targets and dependencies in bazel projects, and it has adwyu(Depend-on What You Use) feature which helps with clean-ups, so it pretty much providesbuild_cleanerfunctionality.The
bant dwyuworks very well on the C++ projects I have tested in on (Verible is so clean as I used an earlier development version of bant on it already; there were tens of findings)).Footnotes
https://github.com/bazelbuild/buildtools/tree/master/buildozer ↩