Re-enable Kythe xRefs publishing #2390
Conversation
| # Bazel renamed @com_google_protobuf to @protobuf while Kythe is still | ||
| # using it in their BUILD targets. Manually rename until the fixed Kythe is | ||
| # released. | ||
| sed -i 's/@com_google_protobuf/@protobuf/' "kythe-${KYTHE_VERSION}/BUILD" |
There was a problem hiding this comment.
there is also repo-mapping, maybe it can work with that ? https://bazel.build/rules/lib/repo/http#http_archive-repo_mapping
There was a problem hiding this comment.
I thought of that. We used it in past. But verible is now using the Bazel modules & I don't see a way how to do remapping with the modules.
|
the problem with clang-tidy is because I don't deal with the forwarding of options yet in .bazelrc, thus the |
| @@ -25,9 +30,6 @@ common:macos --features=-supports_dynamic_linker --linkopt=-framework --linkopt= | |||
| # Since we use designated initializers (C99 ... but >= c++20), compiler really wants the c++20 mode | |||
| common:windows --compiler=clang-cl --cxxopt=/std:c++20 --host_cxxopt=/std:c++20 --client_env=BAZEL_CXXOPTS=/std:c++20 | |||
|
|
|||
| build --cxxopt="-Wno-unknown-warning-option" --host_cxxopt="-Wno-unknown-warning-option" | |||
| # TODO: this looks like benign where it happens but to be explored further | |||
| build --cxxopt="-Wno-dangling-reference" --host_cxxopt="-Wno-dangling-reference" | |||
| # Newer bisons create an unused label. | |||
| build --cxxopt="-Wno-unused-label" --host_cxxopt="-Wno-unused-label" | |||
There was a problem hiding this comment.
Looking at the current windows CI, this -Wno-unused-label also needs to go into our unix-specific config.
There was a problem hiding this comment.
Yep. Added the remaining ones. The windows build is still failing, but on different issues.
|
Hopefully with merging head, the clang-tidy issues should disappear (#2397) |
|
I am fixing the smoke tests separately. |
|
Smoke tests fixed in #2399 |
Bump the Kythe version for the CI. Enable the xRefs action and use newer Ubuntu