Don't use down_cast<> with the assumption that type-mismatch returns … #2423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20250531-limit-down-cast
branch
from
4c88b0c to
5af8645
Compare
…null.
We typically don't compile-in RTTI so relying on down_cast<> returning
nullptr or a correct type will result in subtle issues.
Instead, provide MaybeNode() and MaybeLeaf() that use the SymbolKind
to provide such casts.
This should be expanded:
* Ideally we remove _all_ uses of down_cast<> and use type-safe
ways of doing the same thing (and then: remove verible::down_cast<>).
* There are a few places where we CHECK() fail on type-mismatch, assuming
these can't happen; but that depends on how valid our syntax tree is,
which depends on the input the the parser to reject such input. These
should be reformulated with graceful error handling.
Fixes chipsalliance#2419
hzeller
force-pushed
the
feature-20250531-limit-down-cast
branch
from
5af8645 to
b41588e
Compare
fangism
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…null.
We typically don't compile-in RTTI so relying on down_cast<> returning nullptr or a correct type will result in subtle issues.
Instead, provide MaybeNode() and MaybeLeaf() that use the SymbolKind to provide such casts.
This should be expanded:
Fixes #2419