Provide an 'auto' option for --line_terminator #2426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20250603-line-format-auto
branch
2 times, most recently
from
f4b46cf to
4719e14
Compare
|
I still need to write a test for |
IEncinas10
approved these changes
Jun 4, 2025
hzeller
force-pushed
the
feature-20250603-line-format-auto
branch
2 times, most recently
from
d0d5f68 to
ad9707d
Compare
Also added that test now. |
If 'auto' is chosen, output CRLF line endings if more than 50% of the input is CRLF, otherwise LF. The other choices, CRLF or LF, behave as before. NB: The default changes with this change: previously, we always converted a CRLF input to LF, now the default is 'auto' Issues: chipsalliance#2424 chipsalliance#2370
hzeller
force-pushed
the
feature-20250603-line-format-auto
branch
from
ad9707d to
4f9313d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 'auto' is chosen, output CRLF line endings if more than 50% of the input is CRLF, otherwise LF.
The other choicese, CRLF or LF, behave as before.
NB: The default changes with this change: previously, we always converted a CRLF input to LF, now the default is 'auto'