Wireless profile - Feature template updated #103

md-rafeek · 2025-07-15T06:22:52Z

Type of Change

Bug fix
New feature
Breaking change
Documentation update

Description

Please include a summary of the changes and the related issue. Also, include relevant motivation and context.

Bug Fix: [Brief description of the bug fixed]
Root Cause (if applicable): [Explain what caused the bug]
Fix Implemented: [Describe the fix applied]

Enhancement: [Brief description of the improvement/enhancement made]
Enhancement Description: [Explain what was enhanced, why, and how]
Impact Area: [Mention which part of the system/codebase is affected]

Testing Done:

Manual testing
Unit tests
Integration tests

Test cases covered: [Mention test case IDs or brief points]

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

Tasks are idempotent (can be run multiple times without changing state)
Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
Playbooks are modular and reusable
Handlers are used for actions that need to run on change

Documentation

All options and parameters are documented clearly.
Examples are provided and tested.
Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

…talyst-center-ansible-dev into network_profile_wireless_workflow_manager_dev

madhansansel · 2025-07-28T06:02:36Z

plugins/modules/network_profile_wireless_workflow_manager.py

+        suboptions:
+          device_type:
+            description: |
+                The type of device for which the feature template is applicable.


just fine-tuned, check and update..

The category or name of the feature template to be applied. This defines the functional area of the configuration (For example, AAA, SSID, CleanAir). Only one feature template category can be specified per entry in this list.

The same updated.

madhansansel · 2025-07-28T06:03:56Z

plugins/modules/network_profile_wireless_workflow_manager.py

+                - RRM_FRA_CONFIGURATION
+                - RRM_GENERAL_CONFIGURATION
+            type: str
+            required: false


required: true

if feature_templates is used, then template category is required..

with out device type also can be used, but template_design field is mandatory

madhansansel · 2025-07-28T06:05:59Z

plugins/modules/network_profile_wireless_workflow_manager.py

+            type: str
+            required: false
+          template_design:
+            description: |


fine-tuned.

description: | A list of specific design names or IDs to apply within the chosen feature template category. These designs include various parameters and settings. If "Default Advanced SSID Design" is included in this list, it is comprehensive for SSID configuration, and no other template designs are typically needed for that specific SSID feature. type: list

what is "Default Advanced SSID Design" ? where do we need to include? What are the other options? Is it a choice?

Default Advanced SSID Design is coming under ADVANCED_SSID_CONFIGURATION, in UI we cannot select any other design once selected this.

madhansansel · 2025-07-28T06:06:49Z

plugins/modules/network_profile_wireless_workflow_manager.py

+            required: true
+          applicability_ssids:
+            description: |
+              A list of SSIDs to which this feature template applies.


A list of SSIDs to which this feature template applies. If "Default Advanced SSID Design" is selected for the 'template_design', this feature template will automatically apply to all SSIDs, regardless of this list's content. For example, ["SSID1", "SSID2"].

The same updated.

…talyst-center-ansible-dev into network_profile_wireless_workflow_manager_dev

md-rafeek

Addressed code review comments.

md-rafeek · 2025-07-30T17:53:10Z

plugins/modules/network_profile_wireless_workflow_manager.py

+        suboptions:
+          device_type:
+            description: |
+                The type of device for which the feature template is applicable.


The same updated.

md-rafeek · 2025-07-30T17:54:38Z

plugins/modules/network_profile_wireless_workflow_manager.py

+                - RRM_FRA_CONFIGURATION
+                - RRM_GENERAL_CONFIGURATION
+            type: str
+            required: false


with out device type also can be used, but template_design field is mandatory

md-rafeek · 2025-07-30T17:57:36Z

plugins/modules/network_profile_wireless_workflow_manager.py

+            type: str
+            required: false
+          template_design:
+            description: |


Default Advanced SSID Design is coming under ADVANCED_SSID_CONFIGURATION, in UI we cannot select any other design once selected this.

md-rafeek · 2025-07-30T17:59:01Z

plugins/modules/network_profile_wireless_workflow_manager.py

+            required: true
+          applicability_ssids:
+            description: |
+              A list of SSIDs to which this feature template applies.


The same updated.

DNACENSolutions · 2025-08-04T22:37:20Z

tests/unit/modules/dnac/test_network_profile_wireless_workflow_manager.py

@@ -29,6 +29,7 @@ class TestDnacNetworkWirelessProfileWorkflow(TestDnacModule):

    test_data = loadPlaybookData("network_profile_wireless_workflow_manager")
    profile_creation_config = test_data.get("profile_creation_config")


Add a testcase to test wireless profile with feature template on Catalyst Center version lower then 3.1.3.0 and validate the correct error message is reflected to the user.

added the test case for version.

DNACENSolutions · 2025-08-04T22:39:05Z

plugins/modules/network_profile_wireless_workflow_manager.py

@@ -151,6 +151,50 @@
        type: list
        elements: str
        required: false
+      feature_templates:
+        description: |
+          List of feature templates assigned to the profile.


List of feature templates to be assigned or removed to/from the wireless network profile.

The same updated.

DNACENSolutions · 2025-08-04T22:40:28Z

plugins/modules/network_profile_wireless_workflow_manager.py

+                The category or name of the feature template to be applied.
+                This defines the functional area of the configuration (For example, AAA, SSID, CleanAir).
+                Only one feature template category can be specified per entry in this list.
+                For example:


in place of Example. -> Support Values:

Also include all known values.

updated the same.

DNACENSolutions · 2025-08-04T22:47:43Z

plugins/modules/network_profile_wireless_workflow_manager.py

@@ -1400,6 +1746,36 @@ def compare_config_data(self, input_config, have_info):
                                "WARNING",
                            )

+                if feature_templates:


A supported software version check should be included to guide customer that this is supported from 3.1.3.0 release on wards, if customer provide catalyst center version 2.3.7.9 or older.

updated the same on feature template validation itself.

…talyst-center-ansible-dev into network_profile_wireless_workflow_manager_dev

md-rafeek

addressed code review comments.

md-rafeek · 2025-08-19T18:12:18Z

plugins/modules/network_profile_wireless_workflow_manager.py

@@ -151,6 +151,50 @@
        type: list
        elements: str
        required: false
+      feature_templates:
+        description: |
+          List of feature templates assigned to the profile.


The same updated.

md-rafeek · 2025-08-19T18:13:09Z

plugins/modules/network_profile_wireless_workflow_manager.py

+                The category or name of the feature template to be applied.
+                This defines the functional area of the configuration (For example, AAA, SSID, CleanAir).
+                Only one feature template category can be specified per entry in this list.
+                For example:


updated the same.

md-rafeek · 2025-08-19T18:16:03Z

plugins/modules/network_profile_wireless_workflow_manager.py

@@ -1400,6 +1746,36 @@ def compare_config_data(self, input_config, have_info):
                                "WARNING",
                            )

+                if feature_templates:


updated the same on feature template validation itself.

md-rafeek · 2025-08-19T18:36:38Z

tests/unit/modules/dnac/test_network_profile_wireless_workflow_manager.py

@@ -29,6 +29,7 @@ class TestDnacNetworkWirelessProfileWorkflow(TestDnacModule):

    test_data = loadPlaybookData("network_profile_wireless_workflow_manager")
    profile_creation_config = test_data.get("profile_creation_config")


added the test case for version.

Wireless profile - Feature template updated

117342c

md-rafeek requested a review from madhansansel as a code owner July 15, 2025 06:22

md-rafeek added 4 commits July 15, 2025 22:56

Assurance issue workflow - Change status to success in case no data

0d72c73

Assurance issue workflow - Change status to success in case no data

017baab

Merge branch 'main' of https://github.com/cisco-en-programmability/ca…

ced64c6

…talyst-center-ansible-dev into network_profile_wireless_workflow_manager_dev

Wireless Profile Workflow - UT updated.

f9f5568

madhansansel reviewed Jul 28, 2025

View reviewed changes

md-rafeek added 2 commits July 30, 2025 22:40

Merge branch 'main' of https://github.com/cisco-en-programmability/ca…

779a030

…talyst-center-ansible-dev into network_profile_wireless_workflow_manager_dev

Wireless profile workflow - Updated code review comments

6e202bf

md-rafeek commented Jul 30, 2025

View reviewed changes

DNACENSolutions requested changes Aug 4, 2025

View reviewed changes

md-rafeek added 2 commits August 19, 2025 20:25

Merge branch 'main' of https://github.com/cisco-en-programmability/ca…

ec64e5f

…talyst-center-ansible-dev into network_profile_wireless_workflow_manager_dev

Wireless profile - added the version control for feature template

6813d5c

md-rafeek commented Aug 19, 2025

View reviewed changes

md-rafeek added 4 commits August 20, 2025 00:20

Wireless profile - added the version control for feature template

03d849b

Wireless profile - added the version control for feature template

b0e4a46

Wireless profile - added the version control for feature template

671f7e1

Wireless profile - added the version control for feature template

9054de1

		@@ -29,6 +29,7 @@ class TestDnacNetworkWirelessProfileWorkflow(TestDnacModule):

		test_data = loadPlaybookData("network_profile_wireless_workflow_manager")
		profile_creation_config = test_data.get("profile_creation_config")

Wireless profile - Feature template updated #103

Are you sure you want to change the base?

Wireless profile - Feature template updated #103

Uh oh!

Conversation

md-rafeek commented Jul 15, 2025

Type of Change

Description

Checklist

Ansible Best Practices

Documentation

Screenshots (if applicable)

Notes to Reviewers

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

md-rafeek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

md-rafeek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!