Provision Enhancement

[syed-khadeerahmed]

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update

Description

Added functionality:

1. Deleting wireless provisioned device
2. Added a new parameter called feature template

Bug Fix: NA
Root Cause (if applicable): NA
Fix Implemented: NA

Enhancement: Deletes wireless provisioned device and a new parameter feature template added
Enhancement Description: NA
Impact Area: NA

Testing Done:

• Manual testing
• Unit tests
• Integration tests

Test cases covered: [Mention test case IDs or brief points]

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

• Tasks are idempotent (can be run multiple times without changing state)
• Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
• Playbooks are modular and reusable
• Handlers are used for actions that need to run on change

Documentation

• All options and parameters are documented clearly.
• Examples are provided and tested.
• Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

[DNACENSolutions]

all new fields must be supported.

[DNACENSolutions]

Make it more descriptive, give examples.

[DNACENSolutions]

Make it more descriptive, give examples.

[DNACENSolutions]

Give example from a real test.

[DNACENSolutions]

Missing support for multiple wireless fields:

1. {
   "type": "boolean",
   "required": false,
   "name": "skipApProvision",
   "displayText": "Skip AP Provision",
   "description": "True if Skip AP Provision is enabled, else False"
   },
   {
   "type": "map",
   "address": "uuidfa2e4f30",
   "required": false,
   "name": "rollingApUpgrade",
   "displayText": "Rolling AP Upgrade",
   "description": "Rolling AP Upgrade"
   },
   {
   "type": "string",
   "enum": [],
   "sensitive": false,
   "default": "",
   "constraints": [],
   "required": false,
   "name": "apAuthorizationListName",
   "displayText": "Ap Authorization List Name",
   "description": "AP Authorization List name. 'Obtain the AP Authorization List names by using the API call GET: /intent/api/v1/wirelessSettings/apAuthorizationLists. During re-provision, obtain the AP Authorization List configured for the given provisioned network device Id using the API call GET: /intent/api/v1/wireless/apAuthorizationLists/{networkDeviceId}'"
   },
   {
   "type": "boolean",
   "required": false,
   "name": "authorizeMeshAndNonMeshAccessPoints",
   "displayText": "Authorize Mesh And Non Mesh Access Points",
   "description": "True if AP Authorization List should authorize against All Mesh/Non-Mesh APs, else false if AP Authorization List should only authorize against Mesh APs (Applicable only when Mesh is enabled on sites)"
   },
   {
   "type": "map",
   "address": "uuid789146a0",
   "required": false,
   "name": "featureTemplatesOverridenAttributes",
   "displayText": "Feature Templates Overriden Attributes"
   }

I could not find all these supported on wireless controller provisioning.

[DNACENSolutions]

More missing: {
"type": "boolean",
"required": false,
"name": "enableRollingApUpgrade",
"displayText": "Enable Rolling AP Upgrade",
"description": "True if Rolling AP Upgrade is enabled, else False"
},
{
"type": "integer",
"constraints": [],
"required": false,
"name": "apRebootPercentage",
"displayText": "AP Reboot Percentage",
"description": "AP Reboot Percentage. Permissible values - 5, 15, 25"
}
],
"uuid789146a0": [
{
"type": "array",
"arrayType": "map",
"constraints": [],
"address": "uuid7a58402c",
"required": true,
"name": "editFeatureTemplates",
"displayText": "Edit Feature Templates",
"description": "This array consists of Feature Templates that need to be overridden during the provisioning process for the current provision instance. These edits will not alter the original designs of the Feature Templates but will only apply to the values for the current provisioning instance. Note: Locked attributes cannot be edited in the Provision API. Additionally, default feature templates ('systemTemplate') cannot be included in the payload, as they are not editable."
}
],