Skip to content

bug fix: Do not validate invalid input before running #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2025
Merged

bug fix: Do not validate invalid input before running #298

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dcbdbf
bug fix: Do not validate invalid input before running
Kandarimegha Aug 29, 2025
6cb6666
Merge branch 'main' into network_enhacement_3.0
Kandarimegha Aug 29, 2025
6e39e66
sanity fix
Kandarimegha Aug 29, 2025
0cd991e
addressed review comments
Kandarimegha Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions plugins/modules/network_settings_workflow_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3138,7 +3138,8 @@ def get_global_pool_cidr(self, global_pool_cidr, global_pool_name):
self.log("No matching global pool found in the current batch of results. Continuing to next batch.", "WARNING")

self.log("Failed to find the global pool after exhausting all results.", "ERROR")
return None
self.msg = "Invalid global_pool_name '{0}' under reserve_pool_details".format(global_pool_name)
self.set_operation_result("failed", False, self.msg, "ERROR").check_return_status()

def get_want_global_pool_v1(self, global_ippool):
"""
Expand Down Expand Up @@ -3648,8 +3649,14 @@ def get_want_reserve_pool_v2(self, reserve_pool):
}
self.log(f"Processed IPv4 address space: {ipv4_address_space}", "DEBUG")

# Process IPv6 details if enabledx
# Process IPv6 details if enabled
ipv6_address = item.get("ipv6_address_space")
if ipv6_address is not None and not isinstance(ipv6_address, bool):
self.msg = "Invalid value for 'ipv6_address_space' parameter: '{0}'. Expected boolean value (True or False), but received {1}.".format(
ipv6_address, type(ipv6_address).__name__)
self.log("IPv6 address space validation failed: {0}".format(self.msg), "ERROR")
self.set_operation_result("failed", False, self.msg, "ERROR").check_return_status()

# Check for missing required parameters in the playbook
if ipv6_address is True:
self.log(f"Processing IPv6 details for reserve pool index {reserve_pool_index + 1}.", "DEBUG")
Expand Down
Loading