Skip to content

Endpoint for pretty print migration plan #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Endpoint for pretty print migration plan #3137

wants to merge 17 commits into from

Conversation

Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Aug 7, 2025 •
edited
Loading

Description of Changes

  • Adds endpoint for for pretty printing migration plan.
  • It also changes current publish endpoint to optionally provide MigrationToken and MigrationPolicy to allow migration with breaking clients.

API and ABI breaking changes

Backward compatible change to existing API and new Api

Expected complexity level and risk

2

Testing

  • Existing smoketest should cover changes for publish endpoint.
  • For pretty print endpoint, smoketests can be written only after cli changes.

@Shubham8287 Shubham8287 requested review from gefjon and Centril August 7, 2025 19:22
@Shubham8287 Shubham8287 force-pushed the shub/pretty-endpint branch from 4fca9d9 to 68d0045 Compare August 7, 2025 19:46
@bfops bfops added the release-any To be landed in any release window label Aug 11, 2025
Shubham8287
Shubham8287 commented Aug 13, 2025
View reviewed changes
@Shubham8287
Copy link
Contributor Author

CI is breaking because of base branch.

Shubham8287
Shubham8287 commented Aug 13, 2025
View reviewed changes
gefjon
gefjon reviewed Aug 15, 2025
View reviewed changes
@Shubham8287 Shubham8287 force-pushed the shub/moduledef-pretty-print branch from 88c86e4 to b98e342 Compare August 20, 2025 15:13
Shubham8287 and others added 2 commits September 1, 2025 15:03
@Shubham8287 @gefjon
Update crates/client-api/src/routes/database.rs
ad39f2c 
Co-authored-by: Phoebe Goldman <phoebe@clockworklabs.io>
Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
@Shubham8287 @gefjon
Apply suggestions from code review
fe87c9d 
Co-authored-by: Phoebe Goldman <phoebe@clockworklabs.io>
Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
@Shubham8287 Shubham8287 changed the base branch from shub/moduledef-pretty-print to master September 1, 2025 09:43
@Shubham8287 Shubham8287 requested a review from gefjon September 2, 2025 05:56
@Shubham8287 Shubham8287 added this pull request to the merge queue Sep 5, 2025
@Shubham8287 Shubham8287 removed this pull request from the merge queue due to a manual request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gefjon gefjon gefjon approved these changes

@Centril Centril Awaiting requested review from Centril

Assignees
No one assigned
Labels
release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shubham8287 @gefjon @bfops @kazimuth