Skip to content

Conversation

@anurag2787
Copy link
Contributor

Description

Implemented full support for the auto_pad crop mode in getCldImageUrl, ensuring correct inclusion of g_auto and ar_ parameters.

Issue Ticket Number

Fixes #592

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel
Copy link

vercel bot commented Oct 4, 2025

@anurag2787 is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

@anurag2787
Copy link
Contributor Author

@jlooper-cloudinary Could you please review this pr and let me know if any changes required

@devpatocld
Copy link
Collaborator

@anurag2787 Hi! Your PR is under review. Please be patient, we have several PRs to review. Thank you!

@anurag2787
Copy link
Contributor Author

@devpatocld Could you please review as today is last day of hacktoberfest Thanks!

@eportis-cloudinary
Copy link
Contributor

Hi @anurag2787! I would like to thank you very much for your contribution here, and apologize for my tardry reply/review.

As discussed in the issue, the right layer to add this feature at is not within this library, but in cloudinary-util. @dharamghevariya's merged PR accomplished this, and their subsequent PR to the beta branch of next-cloudinary bumping cloudinary-util versions fixes it here, in next-cloudinary.

As such, I am closing this without merging. Thank you again for your contribution, which was well authored, timely, and directly solved the issue - just not at the architectural layer we wanted to solve it at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support for "auto_pad" crop mode

3 participants