Skip to content

fix(product): MinProduct.children sometimes included parent #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix(product): MinProduct.children sometimes included parent #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion channel_advisor_api/models/channel_advisor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def get_first_image_url(cls, id: str) -> str | None:

@property
def children(self) -> List["MinProduct"]:
return self.all(filter=f"ParentProductID eq {self.id}")
return self.all(filter=f"ParentProductID eq {self.id} and IsParent ne true")

@property
def child_ids(self) -> List[int]:
Expand Down