Add opaque_id to user tests, use opaque_id in functional tests, remove encryption-related dead code #1526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 3 different changes (one in each commit), each building on top of the previous one. I can submit them as separate PRs if you'd prefer that.
One issue I realized just now is that the opaque_ids aren't guaranteed to be globally unique, so technically it's possible for the test suite to fail if it's ran with a pre-existing DB (this will never happen in docker, and well, statistically it's quite unlikely to ever happen to anyone in development either). I guess I could make the AWS endpoint also take a participation ID in the URL and thread the participation ID through the test runner to pass it in the right place, but it seems annoying...
Another alternative is to make opaque_ids a bit longer and globally unique.