Skip to content

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Oct 7, 2025

Backport 1/1 commits from #154866 on behalf of @msbutler.


Previously, the c2c/disconnect roachtest was disconnecting two source nodes, instead of a pair of source/destination nodes. This patch fixes this bug.

Informs: #152248
Informs: #150474

Release note: none


Release justification:

Previously, the c2c/disconnect roachtest was disconnecting to source nodes,
instead of a pair of source/destination nodes.  This patch fixes this bug.

Informs: cockroachdb#152248
Informs: cockroachdb#150474

Release note: none
@msbutler msbutler force-pushed the blathers/backport-release-24.1-154866 branch from b4353c0 to c0aad48 Compare October 7, 2025 22:04
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 7, 2025
@blathers-crl blathers-crl bot requested a review from jeffswenson October 7, 2025 22:04
Copy link

blathers-crl bot commented Oct 7, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-disaster-recovery labels Oct 7, 2025
Copy link

blathers-crl bot commented Oct 7, 2025

❌ PR #155008 does not comply with backport policy

Confidence: high
Explanation: The PR aims to backport a change for the 'c2c/disconnect' roachtest, located within the designated non-production directory 'pkg/cmd/roachtest/'. Although changes in this path are usually treated as non-production and thus exempt from standard backport policies, the PR description does not contain a 'Release justification: .*' line with a valid justification. Additionally, the commit does not fix a critical bug outlined by the specified critical bug criteria nor does it introduce a feature gated by a default-disabled feature flag. The changes seem to address an issue with the test mechanics rather than the database system's stability, security, data handling, or performance.
Recommendation: Reconsider the backport or provide a valid release justification explicit in the PR description.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-failed blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-disaster-recovery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants