Skip to content

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Oct 7, 2025

Backport 1/1 commits from #154866 on behalf of @msbutler.


Previously, the c2c/disconnect roachtest was disconnecting two source nodes, instead of a pair of source/destination nodes. This patch fixes this bug.

Informs: #152248
Informs: #150474

Release note: none


Release justification:

Previously, the c2c/disconnect roachtest was disconnecting to source nodes,
instead of a pair of source/destination nodes.  This patch fixes this bug.

Informs: cockroachdb#152248
Informs: cockroachdb#150474

Release note: none
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 7, 2025
@blathers-crl blathers-crl bot requested a review from jeffswenson October 7, 2025 22:04
Copy link

blathers-crl bot commented Oct 7, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-disaster-recovery labels Oct 7, 2025
Copy link

blathers-crl bot commented Oct 7, 2025

✅ PR #155009 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request addresses changes in a non-production file, specifically within the pkg/cmd/roachtest/ directory, which is explicitly listed as pertaining to development tools and test infrastructure. As per the backport policy, changes that affect only non-production code or tests are exempt from the standard backport policy requirements. Therefore, there is no requirement for this PR to justify a critical bug or to utilize a feature flag. Additionally, the PR does not introduce backward-incompatible changes and does not fall under the criteria of requiring feature-flag gating or further justification for a non-critical bug fix.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Oct 7, 2025
@github-actions github-actions bot merged commit 7ba64bd into cockroachdb:release-24.3 Oct 8, 2025
15 of 16 checks passed
@github-actions github-actions bot deleted the blathers/backport-release-24.3-154866 branch October 8, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-disaster-recovery target-release-24.3.22

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants