Skip to content

Conversation

@andyyang890
Copy link
Collaborator

Backport 1/1 commits from #154802.

/cc @cockroachdb/release


This patch fixes a bug where the memory monitor wouldn't reclaim the
memory allocated to events corresponding to unwatched column families
for a changefeed that targets only a subset of a table's families.

Fixes #154776

Release note (bug fix): A bug where a changefeed targeting only a subset
of a table's column families could become stuck has been fixed.


Release justification: fix for high-severity bug

This patch fixes a bug where the memory monitor wouldn't reclaim the
memory allocated to events corresponding to unwatched column families
for a changefeed that targets only a subset of a table's families.

Release note (bug fix): A bug where a changefeed targeting only a subset
of a table's column families could become stuck has been fixed.
@andyyang890 andyyang890 requested a review from asg0451 October 8, 2025 00:31
@andyyang890 andyyang890 requested a review from a team as a code owner October 8, 2025 00:31
@blathers-crl
Copy link

blathers-crl bot commented Oct 8, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-cdc labels Oct 8, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Oct 8, 2025

✅ PR #155026 is compliant with backport policy

Confidence: high
Critical bug criteria met: [Bugs that can cause the DB to return incorrect results or result in suboptimal performance]
Backward compatible: true
Explanation: The PR backports a bug fix geared towards resolving an issue where a changefeed targeting only a subset of a table's column families could become stuck. The purpose of this fix is clearly to address a significant performance regression and prevent potential data issues related to unprocessed or stuck changefeeds. This complies with the critical bug criteria specified in the backport policy for 'Bugs that can cause the DB to return incorrect results or result in suboptimal performance.'

Additionally, the PR includes a 'Release justification: fix for high-severity bug' in its body, satisfying the release justification clause that exempts it from the standard backport policy requirements regarding feature flags. The files changed do not include non-production files and do not involve backward compatibility issues or removal of version gates. The evidence provided in the PR description and the specific changes justify the backport based on the current policy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@andyyang890 andyyang890 merged commit e190726 into cockroachdb:release-25.2 Oct 8, 2025
16 checks passed
@andyyang890 andyyang890 deleted the backport25.2-154802 branch October 8, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-cdc target-release-25.2.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants