Skip to content

Conversation

esther-anierobi
Copy link
Contributor

Documentation: Create subpages for each source

@esther-anierobi
Copy link
Contributor Author

  1. built-in-source Screenshot 2025-10-04 at 12 17 04
  2. Local File
Screenshot 2025-10-04 at 12 17 55 3. Amazon S3 Screenshot 2025-10-04 at 12 18 38 4. Azure Blob Screenshot 2025-10-04 at 12 19 03 5. Google Drive Screenshot 2025-10-04 at 12 19 25 6. postgres Screenshot 2025-10-04 at 12 19 47

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this file.

@@ -0,0 +1,26 @@
## LocalFile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@badmonster0 badmonster0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do a screenshot of the side bar. and update sidebar.ts also to reflect the source update

@esther-anierobi
Copy link
Contributor Author

Alright, I will do that.

@esther-anierobi
Copy link
Contributor Author

esther-anierobi commented Oct 5, 2025

Bellow is how it looks on the sidebar

  1. Amazon S3Screenshot 2025-10-05 at 00 50 12
  2. LocalFile Screenshot 2025-10-05 at 00 50 34
  3. Google Drive Screenshot 2025-10-05 at 00 51 09
  4. Postgres Screenshot 2025-10-05 at 01 01 39
  5. AzureBlob Screenshot 2025-10-05 at 01 02 41

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls rever package-lock.json yarn.lock changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not reverted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not reverted

docs/sidebars.ts Outdated
collapsed: true,
items: [

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove new line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls revert here

Copy link
Member

@badmonster0 badmonster0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes on this file, we try to keep changes minimal for merge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, revert changes on this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes on this file

docs/sidebars.ts Outdated
link: { type: 'doc', id: 'targets/index' },
collapsed: true,
items: [

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this line.

Copy link
Member

@badmonster0 badmonster0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptal

@esther-anierobi esther-anierobi force-pushed the docs/create-source-subpages-1126 branch from 15c18e2 to b9fff73 Compare October 8, 2025 10:48
@badmonster0
Copy link
Member

Please run npm run start go to docs/sources route and test all the links from that table.

Lets make sure docs/sources#localfile are updated to docs/sources/localfile

and all the links are effective

@esther-anierobi
Copy link
Contributor Author

I have done that and the links are effective.

Should I make a push or send a screenshot?.

@cocoindex-dev
Copy link
Contributor

cocoindex-dev commented Oct 9, 2025

i don't see this change:
docs/sources#localfile are updated to docs/sources/localfile

please also test the links in the table.

Screenshot 2025-10-08 at 10 08 11 PM

@badmonster0
Copy link
Member

lgtm, thanks for the contribution

@badmonster0 badmonster0 merged commit d22f2db into cocoindex-io:main Oct 9, 2025
@esther-anierobi
Copy link
Contributor Author

Thank you so much @badmonster0 for your patience with me, I learned a lot this few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants