-
Notifications
You must be signed in to change notification settings - Fork 223
docs: create subpages for each source (#1126) #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: create subpages for each source (#1126) #1136
Conversation
docs/docs/sources/built-in-source.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this file.
docs/docs/sources/LocalFile.md
Outdated
@@ -0,0 +1,26 @@ | |||
## LocalFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a header to each file, similar to
https://github.com/cocoindex-io/cocoindex/blob/main/docs/docs/targets/kuzu.md?plain=1#L1-L5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do a screenshot of the side bar. and update sidebar.ts also to reflect the source update
Alright, I will do that. |
docs/package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls rever package-lock.json yarn.lock changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still not reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still not reverted
docs/sidebars.ts
Outdated
collapsed: true, | ||
items: [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls revert here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert changes on this file, we try to keep changes minimal for merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto, revert changes on this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert changes on this file
docs/sidebars.ts
Outdated
link: { type: 'doc', id: 'targets/index' }, | ||
collapsed: true, | ||
items: [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ptal
15c18e2
to
b9fff73
Compare
Please run Lets make sure docs/sources#localfile are updated to docs/sources/localfile and all the links are effective |
I have done that and the links are effective. Should I make a push or send a screenshot?. |
lgtm, thanks for the contribution |
Thank you so much @badmonster0 for your patience with me, I learned a lot this few days. |
Documentation: Create subpages for each source