Skip to content

Conversation

Pariharx7
Copy link

@Pariharx7 Pariharx7 commented Oct 6, 2025

resolves #1088

@georgeh0 georgeh0 changed the title Fix/1088 field descriptions Add field descriptions to product_recommendation example Oct 7, 2025
taxonomies: list[ProductTaxonomy]
complementary_taxonomies: list[ProductTaxonomy]
taxonomies: list[ProductTaxonomy] = dataclasses.field(
metadata={"description": "Taxonomies for the current product."}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the standard way to add description for fields.

Please convert these dataclasses to Pydantic models.

Please also test these field descriptions are passed to LLM as expected.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI, thanks for the review!. I noticed the original code used dataclasses for all the defined classes, and my assigned issue (#1088) asked to add field descriptions for the product recommendation example.

Just to confirm - you'd like me to convert these dataclasses to Pydantic models so the field descriptions are correctly recognized by the system?

Thanks again for your guidance!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking. Yes, we would like to convert them to Pydantic models iwth Pydantic field description.

BTW, the issue #1088 linked #1087 which has more background about this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Field Description for Product Recommendation example
2 participants