-
Notifications
You must be signed in to change notification settings - Fork 503
Extract Marketing Sites Deployer Roles from Monolith's IAM Stack #66824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8affed8
to
2a97e9a
Compare
} | ||
|
||
opt_parser = OptionParser.new do |opts| | ||
opts.banner = "Usage: ./deploy.rb [options]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we may want to rename this to deploy-global-resources.rb
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been considering something similar. There will soon be another CloudFormation template in this directory that provisions networking infrastructure that needs to be setup once per account-region. Likely the Ruby shell script in this directory will provision / update both, so I've been thinking of calling it setup-account-and-region
, or just setup
, or maybe keeping deploy
and using the context that it's in the 1-setup
directory, and moving the existing deploy.rb
in the root of the cicd
directory down into 3-app
so that each directory has a deploy
script. Let me know if any of these choices seem like they would work better for our future selves trying to use and maintain this infrastructure code.
Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>
5a0efd5
to
b7e5c11
Compare
Deployed changed to monolith's IAM Stack
|
… that we're replacing.
To facilitate provisioning Marketing Site Stacks in multiple AWS Accounts, start provisioning the deployer Roles in a template that's part of the marketing sites sub-project and deployed separately. Also, enable provisioning of
development
Stacks, but don't permit GitHub Actions to create/updatedevelopment
systems.Testing story
Successfully provisioned a marketing site in the AWS Dev Account, us-east-1 with the following steps:
Deployment strategy
export AWS_PROFILE=codeorg-admin
bundle exec rake stack:iam:start RAILS_ENV=production ADMIN=true
Follow-up work
Privacy
Security
Caching
PR Checklist: