Skip to content

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 27, 2025

This PR includes:

  • added MVP custom lint formatter under tools
  • add lint-formatter to nx.json#defaultTargets

Related:

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling labels Aug 27, 2025
Copy link

nx-cloud bot commented Aug 27, 2025

View your CI Pipeline Execution ↗ for commit 53c5796

Command Status Duration Result
nx code-pushup --nx-bail -- compare --verbose ✅ Succeeded 23s View ↗
nx code-pushup --nx-bail -- --verbose ✅ Succeeded 38s View ↗
nx code-pushup --nx-bail -- print-config --verb... ✅ Succeeded 13m 32s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-29 17:21:39 UTC

Copy link

pkg-pr-new bot commented Aug 27, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1090

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1090

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1090

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1090

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1090

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1090

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1090

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1090

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1090

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1090

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1090

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1090

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1090

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1090

commit: 1592f62

Copy link

github-actions bot commented Aug 27, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 4d20a62 with previous commit a6d3965.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 40 🔴 38 ↓ −2.6
Code style 🟢 100 🟢 99 ↓ −1.1
Code coverage 🟢 90 🟡 90 ↓ −0.5
Bug prevention 🟢 100 🟢 99 ↓ −0.2
Updates 🟡 85 🟡 85 ↑ +0.1
Documentation 🔴 23 🔴 23 ↑ +0.1
Security 🟡 64 🟡 64
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
👍 2 groups improved, 👎 5 groups regressed, 👍 3 audits improved, 👎 11 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
ESLint Module systems (import) 🟢 100 🟡 50 ↓ −50
Lighthouse Performance 🔴 40 🔴 38 ↓ −2.6
ESLint Suggestions 🟢 100 🟢 99 ↓ −1.1
ESLint Problems 🟢 100 🟢 99 ↓ −0.7
Code coverage Code coverage metrics 🟢 90 🟡 90 ↓ −0.5
JS Packages NPM outdated dependencies 🟡 85 🟡 85 ↑ +0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
ESLint Ensure that module boundaries are respected within the monorepo 🟩 passed 🟥 2 errors ↑ +∞ %
ESLint Disallow invocation of require() 🟩 passed 🟥 1 error ↑ +∞ %
ESLint Prefer JavaScript modules (ESM) over CommonJS. 🟩 passed 🟥 1 warning ↑ +∞ %
ESLint Forbid CommonJS require calls and module.exports or exports.*. 🟩 passed 🟥 1 error ↑ +∞ %
Lighthouse Speed Index 🟥 7.2 s 🟥 8.4 s ↑ +17.1 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.5 s ↑ +10.6 %
Lighthouse Largest Contentful Paint 🟥 4.8 s 🟥 4.9 s ↑ +2.4 %
Code coverage Line coverage 🟨 87.5 % 🟨 86.1 % ↓ −1.6 %
Lighthouse Time to Interactive 🟥 17.8 s 🟥 18.3 s ↑ +3 %
JS Packages Outdated NPM dev dependencies. 🟨 50 outdated package versions (21 major, 23 minor, 6 patch) 🟨 50 outdated package versions (21 major, 23 minor, 6 patch)  +0 %
Code coverage Function coverage 🟩 93 % 🟩 92.5 % ↓ −0.5 %
Code coverage Branch coverage 🟨 86.3 % 🟨 86 % ↓ −0.3 %
JSDoc coverage Functions coverage 🟥 519 undocumented functions 🟥 517 undocumented functions ↓ −0.4 %
JSDoc coverage Variables coverage 🟥 230 undocumented variables 🟥 229 undocumented variables ↓ −0.4 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,678 KiB 🟨 Total size was 2,682 KiB ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 16.6 s 🟥 20.2 s ↑ +21.2 %
Lighthouse JavaScript execution time 🟥 6.2 s 🟥 7.9 s ↑ +27.8 %
Lighthouse Total Blocking Time 🟥 5,270 ms 🟥 6,970 ms ↑ +32.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +3 %
Lighthouse Uses efficient cache policy on static assets 🟨 32 resources found 🟨 32 resources found ↑ +0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↓ −35.2 %
Lighthouse Max Potential First Input Delay 🟥 1,700 ms 🟥 1,860 ms ↑ +9.5 %
Lighthouse Initial server response time was short 🟩 Root document took 420 ms 🟩 Root document took 390 ms ↓ −7.4 %
Lighthouse Server Backend Latencies 🟩 1,080 ms 🟩 1,100 ms ↑ +2.3 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 70 ms ↑ +28.9 %
Lighthouse Avoids an excessive DOM size 🟥 2,287 elements 🟥 2,285 elements ↓ −0.1 %
JS Packages Outdated NPM prod dependencies. 🟨 14 outdated package versions (3 major, 6 minor, 5 patch) 🟨 15 outdated package versions (3 major, 7 minor, 5 patch) ↑ +7.1 %

583 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review August 27, 2025 19:13
@BioPhoton BioPhoton requested a review from matejchalk August 28, 2025 14:19
Comment on lines +181 to 195
{
"plugin": "@nx/vite/plugin",
"options": {
"buildTargetName": "build",
"testTargetName": "test",
"serveTargetName": "serve",
"devTargetName": "dev",
"previewTargetName": "preview",
"serveStaticTargetName": "serve-static",
"typecheckTargetName": "typecheck",
"buildDepsTargetName": "build-deps",
"watchDepsTargetName": "watch-deps"
},
"include": ["tools/eslint-multi-format/**"]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use tsc for building the formatter? It would be simpler to stick to the configuration from other projects.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used it to test a newer bundler to experiment a bit with dual build. Can ylso move it to another PR..

"executor": "nx:run-commands",
"options": {
"command": "nx lint {projectName}",
"args": ["--format=./dist/eslint-multi-format/index.js"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a dependsOn to ensure dist/eslint-multi-format exists and is up-to-date?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a bit of a dilemma ... in best case we can run lint independent of build.
For now ill fix it, for future we have to publish eslint fotmatter as separate package (already listed in issue)

BioPhoton and others added 5 commits August 28, 2025 18:37
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 eslint-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants