-
Notifications
You must be signed in to change notification settings - Fork 16
chore: add eslint formatter for multiple formats #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit 53c5796
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/core
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 4d20a62 with previous commit a6d3965. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 5 groups regressed, 👍 3 audits improved, 👎 11 audits regressed, 13 audits changed without impacting score🗃️ Groups
14 other groups are unchanged. 🛡️ Audits
583 other audits are unchanged. |
{ | ||
"plugin": "@nx/vite/plugin", | ||
"options": { | ||
"buildTargetName": "build", | ||
"testTargetName": "test", | ||
"serveTargetName": "serve", | ||
"devTargetName": "dev", | ||
"previewTargetName": "preview", | ||
"serveStaticTargetName": "serve-static", | ||
"typecheckTargetName": "typecheck", | ||
"buildDepsTargetName": "build-deps", | ||
"watchDepsTargetName": "watch-deps" | ||
}, | ||
"include": ["tools/eslint-multi-format/**"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use tsc
for building the formatter? It would be simpler to stick to the configuration from other projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used it to test a newer bundler to experiment a bit with dual build. Can ylso move it to another PR..
"executor": "nx:run-commands", | ||
"options": { | ||
"command": "nx lint {projectName}", | ||
"args": ["--format=./dist/eslint-multi-format/index.js"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be a dependsOn
to ensure dist/eslint-multi-format
exists and is up-to-date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats a bit of a dilemma ... in best case we can run lint independent of build.
For now ill fix it, for future we have to publish eslint fotmatter as separate package (already listed in issue)
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
…nto tools/custom-eslint-formatter
This PR includes:
lint-formatter
tonx.json#defaultTargets
Related:
plugin-eslint
#1068