Skip to content

Add flakiness check status handling in community solution card and model. #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add flakiness check status handling in community solution card and model. #2327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/components/course-page/course-stage-step/community-solution-card/header-label.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
<span class="text-xs font-semibold leading-5 text-gray-700">Private</span>
<EmberTooltip @text="This solution is only visible to users within your team." />
</div>
{{else if (and (eq @solution.flakinessCheckStatus "failure") (current-user-is-staff))}}
<Pill @color="yellow" ...attributes>
Flaky

<EmberTooltip @text="This solution failed tests when run multiple times in a row, so it might not be reliable." />
</Pill>
{{else if @solution.isPinned}}
<Pill @color="green" ...attributes>
Editor's choice
Expand Down
1 change: 1 addition & 0 deletions app/models/community-course-stage-solution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export default class CommunityCourseStageSolutionModel extends Model.extend(View
@attr('number') declare approvedCommentsCount: number;
@attr('string') declare explanationMarkdown: string;
@attr('string') declare commitSha: string;
@attr('string') declare flakinessCheckStatus: 'pending' | 'success' | 'failure' | 'error';
@attr('string') declare githubRepositoryName: string;
@attr('boolean') declare githubRepositoryIsPrivate: boolean;
@attr('boolean') declare isPinned: boolean;
Expand Down
Loading