Skip to content

Using a different technique to gray out logos #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Arpan-206
Copy link
Member

Checklist:

  • I've thoroughly self-reviewed my changes
  • I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
  • I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

Copy link

linear bot commented Jun 30, 2025

@Arpan-206 Arpan-206 requested a review from rohitpaulk June 30, 2025 15:35
Copy link
Contributor

coderabbitai bot commented Jun 30, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 30, 2025

Bundle Report

Changes will decrease total bundle size by 1.63kB (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
client-array-push 38.11MB -1.63kB (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/chunk.*.js 5 bytes 26.68kB 0.02%
assets/chunk.*.js -86 bytes 26.68kB -0.32%
assets/chunk.*.js -1.55kB 3.0MB -0.05%

Copy link

Test Results

  1 files  ±0    1 suites  ±0   9m 55s ⏱️ -2s
633 tests +5  584 ✅ +6  48 💤 ±0  0 ❌ ±0  1 🔥  - 1 
633 runs  +5  583 ✅ +7  48 💤 ±0  1 ❌  - 1  1 🔥  - 1 

For more details on these errors, see this check.

Results for commit ba90b73. ± Comparison against base commit 95d3d19.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
Chrome ‑ error
Chrome 137.0 ‑ Acceptance | course-admin | view-submissions: it should be able to filter by stage(s) through a dropdown menu
Chrome 137.0 ‑ Acceptance | course-admin | view-submissions: it should be accessible if user is course author and authored current course
Chrome 137.0 ‑ Acceptance | course-admin | view-submissions: it should handle null value for tree SHA
Chrome 137.0 ‑ Acceptance | course-admin | view-submissions: it should have the commit SHA in the header
Chrome 137.0 ‑ Acceptance | course-admin | view-submissions: it should have the tree SHA in the header
Chrome 137.0 ‑ Acceptance | course-admin | view-submissions: it should not be accessible if user is course author and did not author current course

Copy link

codecov bot commented Jun 30, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
585 1 584 48
View the top 1 failed test(s) by shortest run time
Chrome 137.0::Acceptance | course-admin | view-tester-version: it has the correct link for viewing releases
Stack Traces | 1.26s run time
Promise rejected during "it has the correct link for viewing releases": Failed to visit URL '.../redis/admin/tester-versions': ChunkLoadError: Loading chunk vendors-components_file-contents-card_ts-components_file-diff-card_ts failed.
(error: http://localhost:7357/assets/chunk.0a3c29f41f4f4f497317.js)

PageObject: 'page.visit("[object Object]")'
  Selector: ':first'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Arpan-206
Copy link
Member Author

@rohitpaulk I'll let you have a look at percy

@rohitpaulk
Copy link
Member

@Arpan-206 ah, this makes the logo opacity pretty variable and distracting (before/after):

Screenshot 2025-06-30 at 11 35 21 Screenshot 2025-06-30 at 11 36 01

We need the logos to still look "solid" and not translucent, only the effective color needs to change.

Copy link
Member

@rohitpaulk rohitpaulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added note

@rohitpaulk
Copy link
Member

Closing due to inactivity

@rohitpaulk rohitpaulk closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants