-
Notifications
You must be signed in to change notification settings - Fork 21
Using a different technique to gray out logos #2929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a different technique to gray out logos #2929
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Bundle ReportChanges will decrease total bundle size by 1.63kB (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
Test Results 1 files ±0 1 suites ±0 9m 55s ⏱️ -2s For more details on these errors, see this check. Results for commit ba90b73. ± Comparison against base commit 95d3d19. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
@rohitpaulk I'll let you have a look at percy |
@Arpan-206 ah, this makes the logo opacity pretty variable and distracting (before/after): ![]() ![]() We need the logos to still look "solid" and not translucent, only the effective color needs to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added note
Closing due to inactivity |
Checklist:
[percy]
in the message to trigger)