feat: add institution route and membership grant component #2956
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| testimonialsData['kang-ming-tay']!, | ||
| testimonialsData['jonathan-lorimer']!, | ||
| testimonialsData['patrick-burris']!, | ||
| ]; |
There was a problem hiding this comment.
Bug: Duplicate Testimonial in Multiple Groups
The testimonial for 'beyang-liu' is duplicated in both testimonialGroup2 and testimonialGroup3 within the testimonialGroups getter. This is likely a copy-paste error, causing the same testimonial to be displayed twice on the page.
Locations (1)
| </div> | ||
|
|
||
| <div class="flex justify-center items-center mb-20"> | ||
| <InstitutionPage::CreateMembershipGrantApplicationContainer class="max-w-xs" /> |
There was a problem hiding this comment.
Bug: Missing Arguments Cause Undefined Values
The InstitutionPage::CreateMembershipGrantApplicationContainer component is invoked without the required @affiliateLink and @course arguments. Its template expects these arguments, which results in undefined values being passed to the nested AffiliateLinkPage::AcceptReferralButton component.
Locations (1)
| <div class="bg-white bg-github-green-dot-wall"> | ||
| <div class="container mx-auto lg:max-w-(--breakpoint-xl) pt-8 sm:pt-16 pb-48 px-3 md:px-6"> | ||
| <div class="space-y-6 text-center max-w-[580px] mx-auto mb-8"> | ||
| <h1 class="text-3xl text-gray-900 font-bold mb-6 md:text-4xl text-balance"> |
There was a problem hiding this comment.
Bug: Template Title and Logo Not Dynamic
The institution.hbs template, intended for generic institution pages, hardcodes the page title to "NUS offer" and the NUS logo URL. Both should be dynamic, based on the institution_slug parameter.
Locations (1)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will increase total bundle size by 7.53kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
Files in
|
No description provided.