Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2025

Bumps web-vitals from 4.2.4 to 5.1.0.

Changelog

Sourced from web-vitals's changelog.

v5.1.0 (2025-07-31)

  • Register visibility-change early (#637)
  • Only finalize LCP on user events (isTrusted=true) (#635)
  • Fallback to default getSelector if custom function is null or undefined (#634)

v5.0.3 (2025-06-11)

  • Remove visibilitychange event listeners when no longer required (#627)

v5.0.2 (2025-05-29)

  • Handle layout shifts with no sources (#623)

v5.0.1 (2025-05-13)

  • Fix missing FCP and LCP for prerendered pages (#621)

v5.0.0 (2025-05-07)

[!NOTE] See the upgrading to v5 guide for a complete list of all API changes in version 5.

  • [BREAKING] Remove the deprecated onFID() function (#519)
  • [BREAKING] Change browser support policy to Baseline Widely available (#525)
  • [BREAKING] Sort the classes that appear in attribution selectors to reduce cardinality (#518)
  • Extend INP attribution with extra LoAF information: longest script and buckets (#592)
  • Add support for generating custom targets in the attribution build (#585)
  • Support multiple calls to onINP() with different config options (#583)
  • Use visibility-state performance entries (#612)
  • Ensure idle callbacks don't run twice (#541) and (#548)
  • Cap nextPaintTime at processingStart (#540) and (#546)
  • Cap INP breakdowns to INP duration (#528)
  • Cap LCP load duration to LCP time (#527)
Commits
  • 1b872cf Release v5.1.0
  • f6cb466 Update CHANGELOG for 5.1.0
  • e5f6e2d Register visibility-change early (#637)
  • 1852851 Only finalize LCP on user events (isTrusted=true) (#635)
  • f16c4b4 Fallback to default getSelector if custom function is null or undefined (#634)
  • 8a54167 Release v5.0.3
  • 61f7c36 Update CHANGELOG for 5.0.3
  • e22d23b Remove visibiliytchange event listeners when no longer required (#627)
  • 1509d64 Upgrade examples in README to v5 (#626)
  • 463abbd Release v5.0.2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [web-vitals](https://github.com/GoogleChrome/web-vitals) from 4.2.4 to 5.1.0.
- [Changelog](https://github.com/GoogleChrome/web-vitals/blob/main/CHANGELOG.md)
- [Commits](GoogleChrome/web-vitals@v4.2.4...v5.1.0)

---
updated-dependencies:
- dependency-name: web-vitals
  dependency-version: 5.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 1, 2025
Copy link

github-actions bot commented Aug 1, 2025

Test Results

643 tests  +1   595 ✅ +1   8m 27s ⏱️ -5s
  1 suites ±0    48 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f8d4b26. ± Comparison against base commit 942217a.

This pull request removes 642 and adds 643 tests. Note that renamed tests count towards both.
Chrome 137.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a collection
Chrome 137.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a course page
Chrome 137.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a track page
Chrome 137.0 ‑ Acceptance | Meta tags: it has default meta image when visiting /catalog
Chrome 137.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: accepting offer when not logged in redirects to login
Chrome 137.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: can accept offer
Chrome 137.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when logged in
Chrome 137.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when not logged in
Chrome 137.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if affiliate link is invalid
Chrome 137.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if course slug is invalid
…
Chrome 139.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a collection
Chrome 139.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a course page
Chrome 139.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a track page
Chrome 139.0 ‑ Acceptance | Meta tags: it has default meta image when visiting /catalog
Chrome 139.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: accepting offer when not logged in redirects to login
Chrome 139.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: can accept offer
Chrome 139.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when logged in
Chrome 139.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when not logged in
Chrome 139.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if affiliate link is invalid
Chrome 139.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if course slug is invalid
…
This pull request removes 48 skipped tests and adds 48 skipped tests. Note that renamed tests count towards both.
Chrome 137.0 ‑ Acceptance | course-page | view-course-stages-test: it should track when the monthly challenge banner is clicked
Chrome 137.0 ‑ Acceptance | track-page | start-track: it display the start-track-button for logged-in user who has not started course in the track
Chrome 137.0 ‑ Acceptance | track-page | start-track: it does not display the start-track-button for logged-in user who has started course in the track
Chrome 137.0 ‑ Acceptance | track-page | start-track: it starts track for logged-in user who has started course in a different track
Chrome 137.0 ‑ Integration | Component | code-mirror > Options > allowInlineDiffs: it does something useful with the editor
Chrome 137.0 ‑ Integration | Component | code-mirror > Options > allowMultipleSelections: it does something useful with the editor
Chrome 137.0 ‑ Integration | Component | code-mirror > Options > autocompletion: it does something useful with the editor
Chrome 137.0 ‑ Integration | Component | code-mirror > Options > bracketMatching: it does something useful with the editor
Chrome 137.0 ‑ Integration | Component | code-mirror > Options > closeBrackets: it does something useful with the editor
Chrome 137.0 ‑ Integration | Component | code-mirror > Options > collapseUnchanged: it does something useful with the editor
…
Chrome 139.0 ‑ Acceptance | course-page | view-course-stages-test: it should track when the monthly challenge banner is clicked
Chrome 139.0 ‑ Acceptance | track-page | start-track: it display the start-track-button for logged-in user who has not started course in the track
Chrome 139.0 ‑ Acceptance | track-page | start-track: it does not display the start-track-button for logged-in user who has started course in the track
Chrome 139.0 ‑ Acceptance | track-page | start-track: it starts track for logged-in user who has started course in a different track
Chrome 139.0 ‑ Integration | Component | code-mirror > Options > allowInlineDiffs: it does something useful with the editor
Chrome 139.0 ‑ Integration | Component | code-mirror > Options > allowMultipleSelections: it does something useful with the editor
Chrome 139.0 ‑ Integration | Component | code-mirror > Options > autocompletion: it does something useful with the editor
Chrome 139.0 ‑ Integration | Component | code-mirror > Options > bracketMatching: it does something useful with the editor
Chrome 139.0 ‑ Integration | Component | code-mirror > Options > closeBrackets: it does something useful with the editor
Chrome 139.0 ‑ Integration | Component | code-mirror > Options > collapseUnchanged: it does something useful with the editor
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 1, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
596 1 595 48
View the top 1 failed test(s) by shortest run time
Chrome::error
Stack Traces | 0s run time
Error: Browser timeout exceeded: 10s
Error while executing test: Acceptance | course-admin | view-submissions: it should be able to filter by stage(s) through a dropdown menu
Stderr: 
 [3420:3709:0813/193858.116188:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3420:3709:0813/193858.117484:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3420:3709:0813/193858.117490:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3420:3709:0813/193858.117494:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3420:3709:0813/193901.685007:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3420:3709:0813/193901.744601:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")

DevTools listening on ws://127.0.0.1:.../devtools/browser/ea5fc3e2-b432-4d42-b836-d7ec1faf712a
[3420:3420:0813/193902.094432:ERROR:dbus/object_proxy.cc:590] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[3420:3420:0813/193902.098533:ERROR:dbus/object_proxy.cc:590] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[3420:3709:0813/193902.098792:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3420:3709:0813/193902.098806:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3420:3420:0813/193902.099361:ERROR:dbus/object_proxy.cc:590] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[3420:5126:0813/193902.132996:ERROR:dbus/object_proxy.cc:590] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= ........./org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[3420:5126:0813/193902.133139:ERROR:dbus/object_proxy.cc:590] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= ........./org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[3420:5126:0813/193902.133372:ERROR:dbus/object_proxy.cc:590] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= ........./org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[3420:3420:0813/193902.135455:ERROR:dbus/object_proxy.cc:590] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[3420:3420:0813/193902.135892:ERROR:dbus/object_proxy.cc:590] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[4826:5067:0813/193902.222139:ERROR:.../ipc/client/command_buffer_proxy_impl.cc:126] ContextResult::kTransientFailure: Failed to send GpuControl.CreateCommandBuffer.
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1755113982.234028    3649 voice_transcription.cc:58] Registering VoiceTranscriptionCapability
[3420:3716:0813/193942.403130:ERROR:.../gcm/engine/mcs_client.cc:700]   Error code: 401  Error message: Authentication Failed: wrong_secret
[3420:3716:0813/193942.403143:ERROR:.../gcm/engine/mcs_client.cc:702] Failed to log in to GCM, resetting connection.
[3420:3716:0813/193942.404704:ERROR:.../gcm/engine/registration_request.cc:291] Registration response error message: PHONE_REGISTRATION_ERROR
[3420:3716:0813/193942.406112:ERROR:.../gcm/engine/registration_request.cc:291] Registration response error message: PHONE_REGISTRATION_ERROR

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

codecov bot commented Aug 1, 2025

Bundle Report

Changes will decrease total bundle size by 1.15kB (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
client-array-push 38.63MB -1.15kB (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/chunk.*.js -1.15kB 3.1MB -0.04%

@rohitpaulk
Copy link
Member

@cursor can you remove the onFID integration we have? Look like this is deprecated now

Copy link

cursor bot commented Aug 13, 2025

I removed the tracking and reporting of the First Input Delay (FID) web vital metric from the application's web vitals service. This change streamlines the performance metrics collected, focusing on other more current or relevant indicators.

  • I removed the onFID import from the web-vitals library in app/services/web-vitals.ts.
  • I stopped reporting the FID metric by removing the onFID((metric) => this.reportMetric(metric)); call within the setupReporting method of app/services/web-vitals.ts.

Open in Cursor Open in Web

Learn more about Cursor Agents

Co-authored-by: rohitpaulk <rohitpaulk@gmail.com>
@rohitpaulk rohitpaulk merged commit aa69773 into main Aug 14, 2025
10 of 11 checks passed
@rohitpaulk rohitpaulk deleted the dependabot/npm_and_yarn/web-vitals-5.1.0 branch August 14, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants