refactor: simplify affiliate referral status display logic #2973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will decrease total bundle size by 1.0kB (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
Files in
|
rohitpaulk
force-pushed
the
refactor-simplify-affiliate-referral-status
branch
from
b661b74 to
245012a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| <EmberTooltip @text="This user either joined a paid team account or availed a separate discount." /> | ||
| </Pill> | ||
| {{/if}} |
There was a problem hiding this comment.
Bug: Legacy Affiliate Statuses Incorrectly Marked Inactive
Affiliate referrals with legacy statuses ('trialing', 'pending_trial', 'trial_cancelled') incorrectly display as "Inactive". The updated template logic only checks for statusIsAwaitingFirstCharge and statusIsFirstChargeSuccessful, causing unhandled old statuses to fall through to the default "Inactive" state and misrepresent active trials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of CC-1888