Skip to content

Conversation

VasylMarchuk
Copy link
Collaborator

@VasylMarchuk VasylMarchuk commented Aug 3, 2025

Follow-up to: #2949

Brief

This is an experiment to migrate away from using array prototype extensions

Checklist

  • I've thoroughly self-reviewed my changes
  • I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
  • I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

@VasylMarchuk VasylMarchuk self-assigned this Aug 3, 2025
@VasylMarchuk VasylMarchuk added the experiment Pull requests created with experimenting purposes label Aug 3, 2025
Copy link

github-actions bot commented Aug 3, 2025

Test Results

  1 files  ±0    1 suites  ±0   4m 19s ⏱️ - 4m 23s
650 tests ±0  306 ✅  - 296  48 💤 ±0    0 ❌ ±  0  296 🔥 +296 
650 runs  ±0   10 ✅  - 592  48 💤 ±0  296 ❌ +296  296 🔥 +296 

For more details on these errors, see this check.

Results for commit 8f31ad3. ± Comparison against base commit 872bc39.

♻️ This comment has been updated with latest results.

@VasylMarchuk VasylMarchuk force-pushed the disable-prototype-extensions branch from b0e39b3 to 8c24e95 Compare August 5, 2025 15:32
Copy link

codecov bot commented Aug 5, 2025

❌ 296 Tests Failed:

Tests completed Failed Passed Skipped
602 296 306 48
View the top 3 failed test(s) by shortest run time
Chrome 139.0::Acceptance | course-page | complete-second-stage: can complete second stage
Stack Traces | 0.032s run time
Promise rejected during "can complete second stage": repository.course.stages.models.sortBy is not a function
Chrome 139.0::Acceptance | course-page | try-other-language: can try other language
Stack Traces | 0.035s run time
Promise rejected during "can try other language": repository.course.stages.models.sortBy is not a function
Chrome 139.0::Acceptance | course-page | extensions | disable-extensions: can disable extensions when viewing an extension stage
Stack Traces | 0.037s run time
Promise rejected during "can disable extensions when viewing an extension stage": repository.course.stages.models.sortBy is not a function

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

codecov bot commented Aug 5, 2025

Bundle Report

Changes will increase total bundle size by 4.22kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
client-array-push 38.53MB 4.22kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/chunk.*.js 3.75kB 3.14MB 0.12%
assets/chunk.*.js 82 bytes 27.14kB 0.3%
assets/chunk.*.js 44 bytes 26.62kB 0.17%
assets/chunk.*.js 5 bytes 331.38kB 0.0%
assets/chunk.*.js 244 bytes 407.87kB 0.06%
assets/chunk.*.js 93 bytes 11.98kB 0.78%

Files in assets/chunk.*.js:

  • ./controllers/course-overview.ts → Total Size: 1.77kB

  • ./models/course-extension.ts → Total Size: 2.46kB

  • ./models/course-stage.ts → Total Size: 14.29kB

  • ./controllers/track.ts → Total Size: 1.6kB

  • ./controllers/catalog.ts → Total Size: 5.41kB

  • ./controllers/join-track.ts → Total Size: 1.57kB

  • ./controllers/roadmap/course-ideas.ts → Total Size: 1.26kB

  • ./models/affiliate-referral.ts → Total Size: 3.9kB

  • ./models/concept-engagement.ts → Total Size: 3.31kB

  • ./controllers/roadmap/course-extension-ideas.ts → Total Size: 2.76kB

Files in assets/chunk.*.js:

  • ./controllers/course.ts → Total Size: 12.88kB

  • ./controllers/course/stage/instructions.ts → Total Size: 6.95kB

Files in assets/chunk.*.js:

  • ./controllers/badges.ts → Total Size: 1.7kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment Pull requests created with experimenting purposes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant