Skip to content

Inline markdown #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Inline markdown #5

wants to merge 9 commits into from

Conversation

megamaths
Copy link
Collaborator

Added inline markdown like ability to add italics bold and monospaced (via */_, **/__, `) through the new md attribute instead of the text attribute.

Copy link
Owner

@codedstructure codedstructure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing, inline code format doesn't work fully, e.g. md="test `a*` test" should show a* in monospace, but doesn't. Try testing against the github comment preview window!

The markdown parsing / splitting should be extracted to a separate markdown.rs file.

Copy link
Owner

@codedstructure codedstructure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a basic example in examples/markdown.xml would be useful, even something as simple as the following, though multiple lines etc would be better.

<svg>
  <rect wh="50 10" md="**Hello** _Markdown_ `world`!"/>
</svg>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants