fix: TypeError in DataCaster initialization

[neznaika0]

Description

• Fixed a bug where new DataCaster() caused the error TypeError: array_merge(): Argument #2 must be of type array, null given
• Added a method check for castAs() and a test.
• PHPDoc has been cleaned in BaseCast

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

The two checks conflict. What is the best way to fix it?
Update PHPDoc, add ignore, or remove exception?

[michalsn]

Do you think this exception is necessary? The PHPDoc already makes it clear.

[neznaika0]

phpDoc will not help if the user uses a different method (in notepad++).
Secondly, I've been thinking about it too. Then we can remove the exception and translation.

[michalsn]

Then we can remove the exception and transfer.

I'm afraid I don't fully understand what you mean.

Since this isn't directly used by the end user, I'd stick with the PHPDoc. It has worked fine so far - unless there's a specific reason for adding this check?

[neznaika0]

Sorry. Typo "translation".
Yes, it works. Then we have the dead code in the CastException. I decided that the check is necessary if an exception is planned. Or delete exception method.

[michalsn]

This exception was previously used in the entity cast.

Let's hold off for now and hear what others think. If you feel it's more valuable to keep the exception and make the PHPDoc less strict, that's fine too.

[paulbalandan]

should this also have the CastInterface and EnityCastInterface as above?

[neznaika0]

Since we've decided on separate typing, I'm unsure about specifying the types...

[paulbalandan]

I'm now wondering if the framework should be the one adjusting for this missing support of phpDocumentor. I feel we are being redundant in our PHPDocs just because our API tool does not yet support a feature that is widely used now. Should this be a feature request to them (to support phpstan types and conditional returns?).

[michalsn]

Is there an alternative to phpDocumentor that would handle it better?

[neznaika0]

For a small project, I would ignore the duplication and rely on the phpstan. types.
Looking at symfony, they don't bother with this.
There is a slightly different option, which is more complex - to use a Value Object, DTO instead of an array.