chore: add connect/disconnect notifications on Coder Connect #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jul 1, 2025
Comment on lines
+342
to
+343
| var app = (App)Current; | ||
| if (app != null && app.TrayWindow != null) |
There was a problem hiding this comment.
Shouldn't this just be if (TrayWindow != null) TrayWindow.Tray_Open();?
|
|
||
| private ConcurrentDictionary<string, INotificationHandler> Handlers { get; } = new(); | ||
|
|
||
| public UserNotifier(ILogger<UserNotifier> logger, IDispatcherQueueManager dispatcherQueueManager, | ||
| INotificationHandler notificationHandler) |
There was a problem hiding this comment.
Perhaps we should wrap it with a marker type like public interface IDefaultNotificationHandler : INotificationHandler so we don't inadvertently add another implementation that could get DI'd here, and only have the App implement IDefaultNotificationHandler
Comment on lines
+157
to
+166
| // This method is called when the state changes, but we don't want to notify | ||
| // the user if the state hasn't changed. | ||
| var isRpcLifecycleChanged = rpcModel.RpcLifecycle == RpcLifecycle.Disconnected && curRpcLifecycle != rpcModel.RpcLifecycle; | ||
| var isVpnLifecycleChanged = (rpcModel.VpnLifecycle == VpnLifecycle.Started || rpcModel.VpnLifecycle == VpnLifecycle.Stopped) && curVpnLifecycle != rpcModel.VpnLifecycle; | ||
|
|
||
| if (!isRpcLifecycleChanged && !isVpnLifecycleChanged) | ||
| { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think you need any of these lines since they're essentially covered by what's below right?
There was a problem hiding this comment.
Unfortunately no, I ignore the intermediate states of the Vpn lifecycle on purpose (and I don't update the prevRpcLifecycle for that reason).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #40