-
Notifications
You must be signed in to change notification settings - Fork 1
impl: support uri handling #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
ee07b8d
ba78918
0661a8d
5b7f3e9
3108f7d
0403ee2
86532d4
56ed322
0b49bcb
894bcab
21f012d
00f9ab3
b67585f
9f096cf
2cd3565
d3a483e
20441c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,7 +60,6 @@ fun ensureCLI( | |
deploymentURL: URL, | ||
buildVersion: String, | ||
settings: CoderSettings, | ||
indicator: ((t: String) -> Unit)? = null, | ||
): CoderCLIManager { | ||
val cli = CoderCLIManager(deploymentURL, context.logger, settings) | ||
|
||
|
@@ -76,7 +75,7 @@ fun ensureCLI( | |
|
||
// If downloads are enabled download the new version. | ||
if (settings.enableDownloads) { | ||
indicator?.invoke("Downloading Coder CLI...") | ||
context.logger.info("Downloading Coder CLI...") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we also log what version of CLI is being downloaded and the source URL? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is using https://dev.coder.com/bin/ to download the binary, and it doesn't contain the version. I think the version can be resolved only after running the cli, which means much later than this log. |
||
try { | ||
cli.download() | ||
return cli | ||
|
@@ -98,7 +97,7 @@ fun ensureCLI( | |
} | ||
|
||
if (settings.enableDownloads) { | ||
indicator?.invoke("Downloading Coder CLI...") | ||
context.logger.info("Downloading Coder CLI...") | ||
dataCLI.download() | ||
return dataCLI | ||
} | ||
|
Uh oh!
There was an error while loading. Please reload this page.