Skip to content

Conversation

artberger
Copy link

Changes

In sequence diagrams, if you add numbering, the background circle was too dark to read the numbers in light mode. See screenshots below.

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

I am not sure whether this needs a changelog entry or where to do that.

Documentation

  • Docs have been updated --> I updated the sample site to add numbering to the sample mermaid sequence diagram
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

Light mode before

image

Dark mode before

image

Light mode now

image

Dark mode now

image

In sequence diagrams, if you add numbering, the background circle was too dark to read the numbers in light mode.
Copy link

netlify bot commented May 7, 2025

Deploy Preview for hugo-lotusdocs ready!

Name Link
🔨 Latest commit 15bb49d
🔍 Latest deploy log https://app.netlify.com/projects/hugo-lotusdocs/deploys/683ddb5c68300e00073b77f4
😎 Deploy Preview https://deploy-preview-237--hugo-lotusdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@artberger
Copy link
Author

Hi @colinwilson, I noticed a small issue with the background color in the number of mermaid diagrams, so I opened this small PR.

@colinwilson colinwilson added this to the v0.3.0 milestone Jun 2, 2025
@colinwilson colinwilson added the improvment Improve an existing feature label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvment Improve an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants