Add bit depth option (16/24-bit) to SaveAudio node #7629
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuziekMagie
requested review from
yoland68,
robinjhuang,
huchenlei,
pythongosssss,
ltdrdata,
Kosinkadink and
webfiltered
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
bit_depthinput to theSaveAudionode, allowing users to choose between 16-bit and 24-bit FLAC output.Why this is useful:
24-bit audio provides higher dynamic range and better fidelity, which can be helpful for audio processing, editing, or mastering workflows. This gives users more control over audio quality when needed.
Changes:
bit_depthinput (16 or 24) to the nodebits_per_sampletotorchaudio.save()accordinglyNo breaking changes—existing setups will continue to work as before.