Skip to content

LiteLLM Script #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Aug 18, 2025
Merged

LiteLLM Script #786

merged 31 commits into from
Aug 18, 2025
+180 −0

Conversation

stout01
Copy link
Contributor

@stout01 stout01 commented Aug 8, 2025 •
edited
Loading

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.

✍️ Description

Adds LiteLLM LXC Script

🔗 Related PR / Issue

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

image image

@stout01
Copy link
Contributor Author

stout01 commented Aug 8, 2025

No hardcoded credentials

The master key is hardcoded. It is used for the admin login. Is there a better way to handle this?
If it is auto-generated, is it okay to print out to the user?

@stout01 stout01 marked this pull request as ready for review August 8, 2025 00:40
@stout01 stout01 requested review from a team as code owners August 8, 2025 00:40
stout01
stout01 commented Aug 8, 2025
View reviewed changes
install/litellm-install.sh
Comment on lines +52 to +53
general_settings:
master_key: sk-1234
database_url: postgresql://$DB_USER:$DB_PASS@127.0.0.1:5432/$DB_NAME
store_model_in_db: true
EOF
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only just started using litellm. This config is working for me...
Their docs have a production best practices page. I haven't gone through it yet.
https://docs.litellm.ai/docs/proxy/prod

CrazyWolf13
CrazyWolf13 requested changes Aug 8, 2025
View reviewed changes
Copy link
Member

@CrazyWolf13 CrazyWolf13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but looks already pretty good, thx

install/litellm-install.sh Outdated
Comment on lines 17 to 21
$STD apt-get install -y \
python3 \
python3-dev \
python3-pip
rm -rf /usr/lib/python3.*/EXTERNALLY-MANAGED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an uv based venv, to follow suggestions in this PR:
community-scripts/ProxmoxVE#4961

community-scripts/ProxmoxVE#3705

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored to use UV.
I'm not the most familiar with python. Let me know if I missed anything there.

.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you cleanly re-add this with only this line:

.vscode/settings.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, didn't mean to cause trouble. Those ds store files can get annoying.

@stout01 stout01 force-pushed the ved-litellm-script branch 3 times, most recently from 3f256d7 to 89c3c77 Compare August 8, 2025 21:54
@stout01 stout01 requested a review from CrazyWolf13 August 8, 2025 22:06
MickLesk
MickLesk requested changes Aug 12, 2025
View reviewed changes
@stout01 stout01 force-pushed the ved-litellm-script branch from c8ad15f to 2b8ac54 Compare August 16, 2025 20:08
MickLesk
MickLesk requested changes Aug 16, 2025
View reviewed changes
Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Changes of func Files in this PR, i Check it at monday

@stout01 stout01 marked this pull request as draft August 16, 2025 20:42
@stout01
Copy link
Contributor Author

stout01 commented Aug 17, 2025

Remove Changes of func Files in this PR, i Check it at monday

Sorry about the pings, I added that in for testing. Should be all set for another review.

@stout01 stout01 marked this pull request as ready for review August 17, 2025 02:16
@stout01 stout01 requested a review from MickLesk August 17, 2025 02:16
@MickLesk MickLesk mentioned this pull request Aug 18, 2025
Open
@MickLesk MickLesk merged commit 62eb0cc into community-scripts:main Aug 18, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MickLesk MickLesk MickLesk approved these changes

@CrazyWolf13 CrazyWolf13 Awaiting requested review from CrazyWolf13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stout01 @MickLesk @CrazyWolf13