Moodle #813

EEJoshua · 2025-08-18T20:54:29Z

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.

✍️ Description

Install script for moodle

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No breaking changes – Existing functionality remains intact.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

Follows Code_Audit.md & CONTRIBUTING.md guidelines
Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
No hardcoded credentials

📋 Additional Information (optional)

MickLesk

First quick review

MickLesk · 2025-08-18T20:56:25Z

frontend/public/json/moodle.json

+        "password": null
+    },
+    "notes": [
+        "Database and Admin credentials are saved in ~/moodle.creds",


Notes need an Type and must be seperate. Checkout the json-editor on our Site:
https://community-scripts.github.io/ProxmoxVE/json-editor

MickLesk · 2025-08-18T20:57:06Z

install/moodle-install.sh

+msg_info "Installing Web & DB stack"
+$STD apt-get install -y apache2 mariadb-server git unzip \
+  php libapache2-mod-php \
+  php-mysql php-zip php-xml php-gd php-curl \


We have seperate functions for PHP, mariadb and co. Checkout other Scripts or our tools.func in misc

MickLesk · 2025-08-18T20:58:24Z

install/moodle-install.sh

+msg_ok "Selecting Moodle branch"
+REMOTE_BRANCHES="$(git ls-remote --heads https://github.com/moodle/moodle.git 'MOODLE_*_STABLE' | awk -F'refs/heads/' '{print $2}' | sort -V)"
+echo "Available stable branches:"
+echo "${REMOTE_BRANCHES}"
+echo -n "Enter branch to install [default MOODLE_500_STABLE]: "
+read -r MOODLE_BRANCH
+MOODLE_BRANCH="${MOODLE_BRANCH:-MOODLE_500_STABLE}"
+if ! echo "${REMOTE_BRANCHES}" | grep -qx "${MOODLE_BRANCH}"; then
+  msg_error "Branch ${MOODLE_BRANCH} not found among remotes"
+  exit 1
+fi
+msg_ok "Selected ${MOODLE_BRANCH}"
+
+msg_info "Cloning Moodle (shallow)"
+install -d -m 0755 /var/www
+$STD rm -rf /var/www/moodle
+$STD git clone --depth 1 --branch "${MOODLE_BRANCH}" https://github.com/moodle/moodle.git /var/www/moodle
+msg_ok "Cloned Moodle ${MOODLE_BRANCH}"
+
+msg_info "Setting permissions and data directory"
+install -d -m 0770 -o www-data -g www-data /var/moodledata


Why so much effort? Just use function "fetch_and_deploy_gh_release "moodle"....

MickLesk · 2025-08-18T20:59:00Z

install/moodle-install.sh

+msg_info "PHP tuning (CLI and Apache)"
+PHPVER="$(php -r 'echo PHP_MAJOR_VERSION.".".PHP_MINOR_VERSION;')" || true
+if [[ -z "$PHPVER" ]]; then
+  PHPVER="$(ls -1d /etc/php/* 2>/dev/null | awk -F'/' '{print $4}' | head -n1)"
+fi
+if [[ -z "$PHPVER" ]]; then
+  msg_error "Unable to determine PHP version path under /etc/php"
+  exit 1
+fi
+for sapi in apache2 cli; do
+  install -d -m 0755 "/etc/php/${PHPVER}/${sapi}/conf.d"
+  {
+    echo "max_input_vars=5000"
+    echo "memory_limit=256M"
+  } >"/etc/php/${PHPVER}/${sapi}/conf.d/99-moodle.ini"
+done
+$STD systemctl reload apache2
+msg_ok "PHP tuned"


Most of this is not needed with setup_php function

This reverts commit 317c6f6.

tremor021 · 2025-08-30T21:02:39Z

install/moodle-install.sh

+MARIADB_VERSION="latest"
+export MARIADB_VERSION


Suggested change

MARIADB_VERSION="latest"

export MARIADB_VERSION

tremor021 · 2025-08-30T21:02:55Z

install/moodle-install.sh

+MARIADB_VERSION="latest"
+export MARIADB_VERSION
+setup_mariadb
+msg_ok "MariaDB ready"


Suggested change

msg_ok "MariaDB ready"

tremor021 · 2025-08-30T21:03:05Z

install/moodle-install.sh

+setup_php
+msg_ok "PHP ready"
+
+msg_info "Install MariaDB"


Suggested change

msg_info "Install MariaDB"

tremor021 · 2025-08-30T21:05:21Z

install/moodle-install.sh

+msg_info "Install PHP (Apache) + required modules"
+$STD apt-get install -y git
+PHP_VERSION="8.2"
+PHP_APACHE="YES"
+PHP_FPM="NO"
+PHP_MODULE="bcmath,curl,gd,intl,mbstring,opcache,readline,xml,zip,mysql,soap,ldap"
+PHP_MEMORY_LIMIT="256M"
+export PHP_VERSION PHP_APACHE PHP_FPM PHP_MODULE PHP_MEMORY_LIMIT
+setup_php
+msg_ok "PHP ready"


Suggested change

msg_info "Install PHP (Apache) + required modules"

$STD apt-get install -y git

PHP_VERSION="8.2"

PHP_APACHE="YES"

PHP_FPM="NO"

PHP_MODULE="bcmath,curl,gd,intl,mbstring,opcache,readline,xml,zip,mysql,soap,ldap"

PHP_MEMORY_LIMIT="256M"

export PHP_VERSION PHP_APACHE PHP_FPM PHP_MODULE PHP_MEMORY_LIMIT

setup_php

msg_ok "PHP ready"

PHP_VERSION="8.2" PHP_APACHE="YES" PHP_MODULE="mysql,soap,ldap" PHP_MEMORY_LIMIT="256M" setup_php

tremor021 · 2025-08-30T21:07:12Z

install/moodle-install.sh

+msg_ok "Selecting Moodle branch"
+REMOTE_BRANCHES="$(git ls-remote --heads https://github.com/moodle/moodle.git 'MOODLE_*_STABLE' | awk -F'refs/heads/' '{print $2}' | sort -V)"
+echo "Available stable branches:"
+echo "${REMOTE_BRANCHES}"
+echo -n "Enter branch to install [default MOODLE_500_STABLE]: "
+read -r MOODLE_BRANCH
+MOODLE_BRANCH="${MOODLE_BRANCH:-MOODLE_500_STABLE}"
+if ! echo "${REMOTE_BRANCHES}" | grep -qx "${MOODLE_BRANCH}"; then
+  msg_error "Branch ${MOODLE_BRANCH} not found among remotes"
+  exit 1
+fi
+msg_ok "Selected ${MOODLE_BRANCH}"
+
+msg_info "Cloning Moodle (shallow)"
+install -d -m 0755 /var/www
+$STD rm -rf /var/www/moodle
+$STD git clone --depth 1 --branch "${MOODLE_BRANCH}" https://github.com/moodle/moodle.git /var/www/moodle
+msg_ok "Cloned Moodle ${MOODLE_BRANCH}"


Suggested change

msg_ok "Selecting Moodle branch"

REMOTE_BRANCHES="$(git ls-remote --heads https://github.com/moodle/moodle.git 'MOODLE_*_STABLE' | awk -F'refs/heads/' '{print $2}' | sort -V)"

echo "Available stable branches:"

echo "${REMOTE_BRANCHES}"

echo -n "Enter branch to install [default MOODLE_500_STABLE]: "

read -r MOODLE_BRANCH

MOODLE_BRANCH="${MOODLE_BRANCH:-MOODLE_500_STABLE}"

if ! echo "${REMOTE_BRANCHES}" | grep -qx "${MOODLE_BRANCH}"; then

msg_error "Branch ${MOODLE_BRANCH} not found among remotes"

exit 1

fi

msg_ok "Selected ${MOODLE_BRANCH}"

msg_info "Cloning Moodle (shallow)"

install -d -m 0755 /var/www

$STD rm -rf /var/www/moodle

$STD git clone --depth 1 --branch "${MOODLE_BRANCH}" https://github.com/moodle/moodle.git /var/www/moodle

msg_ok "Cloned Moodle ${MOODLE_BRANCH}"

Dont use git clone, use fetch_and_deploy_gh_release function

tremor021 · 2025-08-30T21:10:55Z

ct/moodle.sh

@@ -0,0 +1,56 @@
+#!/usr/bin/env bash
+source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)


Suggested change

source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)

source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/misc/build.func)

tremor021 · 2025-08-30T21:12:25Z

ct/moodle.sh

+
+  msg_info "Preparing repository"
+  $STD git config --system --add safe.directory /var/www/moodle || true
+
+  BRANCH="$(runuser -u www-data -- git -C /var/www/moodle rev-parse --abbrev-ref HEAD 2>/dev/null || echo 'MOODLE_500_STABLE')"
+  msg_info "Updating $APP (${BRANCH})"
+  $STD runuser -u www-data -- git -C /var/www/moodle fetch --all --prune
+  $STD runuser -u www-data -- git -C /var/www/moodle checkout -B "${BRANCH}" "origin/${BRANCH}"
+  $STD runuser -u www-data -- git -C /var/www/moodle reset --hard "origin/${BRANCH}"


Please don't use git

tremor021 · 2025-08-30T21:13:16Z

frontend/public/json/moodle.json

+    "interface_port": 80,
+    "documentation": "https://docs.moodle.org/500/en/Main_page",
+    "website": "https://moodle.org/",
+    "logo": "https://moodle.org/theme/image.php/moodleorg/core/1720531200/moodle-logo",


Suggested change

"logo": "https://moodle.org/theme/image.php/moodleorg/core/1720531200/moodle-logo",

"logo": "https://cdn.jsdelivr.net/gh/selfhst/icons/webp/moodle.webp",

tremor021 · 2025-08-30T21:13:50Z

frontend/public/json/moodle.json

+    },
+    "notes": [
+        { "type": "info", "text": "Database and Admin credentials are saved in ~/moodle.creds" },
+        { "type": "warning", "text": "Moodle requires PHP settings: max_input_vars >= 5000 and memory_limit >= 256M. These are applied automatically." },


Suggested change

{ "type": "warning", "text": "Moodle requires PHP settings: max_input_vars >= 5000 and memory_limit >= 256M. These are applied automatically." },

Not needed

tremor021 · 2025-08-30T21:14:10Z

frontend/public/json/moodle.json

+        { "type": "info", "text": "Database and Admin credentials are saved in ~/moodle.creds" },
+        { "type": "warning", "text": "Moodle requires PHP settings: max_input_vars >= 5000 and memory_limit >= 256M. These are applied automatically." },
+        { "type": "info", "text": "Default data directory: /var/moodledata (writeable by www-data)." },
+        { "type": "info", "text": "Supports MariaDB as the database backend (configured by the script)." }


Suggested change

{ "type": "info", "text": "Supports MariaDB as the database backend (configured by the script)." }

Not needed

DESKTOP-UULMCR6\Joshua added 11 commits August 18, 2025 22:46

Initial scripts

e026e6e

url edits

4831c9d

url update

2aedfcd

msg cleanup

d46bfa6

var bug

6d88557

Branch selection fix

df3e81b

msg fix

d72b56c

Revert urls

4b5cf6a

Unnecessary prints

9a96648

Update script fix

3f06a86

update script

0bf1ddd

EEJoshua requested review from a team as code owners August 18, 2025 20:54

MickLesk requested changes Aug 18, 2025

View reviewed changes

michelroegl-brunner force-pushed the main branch from db57a72 to b1a3b4d Compare August 18, 2025 22:29

Using built in functions for mariadb and php

1043708

github-actions bot added new script website maintenance core high risk labels Aug 30, 2025

DESKTOP-UULMCR6\Joshua added 4 commits August 30, 2025 23:33

+ git

e5f1adc

Use github deploy

317c6f6

Revert "Use github deploy"

613ffce

This reverts commit 317c6f6.

Revert urls

b675ca8

tremor021 reviewed Aug 30, 2025

View reviewed changes

install/moodle-install.sh

setup_php

msg_ok "PHP ready"

msg_info "Install MariaDB"

Copy link

Member

tremor021 Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

msg_info "Install MariaDB"

tremor021 reviewed Aug 30, 2025

View reviewed changes

		@@ -0,0 +1,56 @@
		#!/usr/bin/env bash
		source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)

	"logo": "https://moodle.org/theme/image.php/moodleorg/core/1720531200/moodle-logo",
	"logo": "https://cdn.jsdelivr.net/gh/selfhst/icons/webp/moodle.webp",

Uh oh!

Moodle #813

Are you sure you want to change the base?

Moodle #813

Uh oh!

Conversation

EEJoshua commented Aug 18, 2025

✍️ Description

🔗 Related PR / Issue

✅ Prerequisites (X in brackets)

🛠️ Type of Change (X in brackets)

🔍 Code & Security Review (X in brackets)

📋 Additional Information (optional)

Uh oh!

MickLesk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tremor021 Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tremor021 Aug 30, 2025 •

edited

Loading