Use check-xeus-cpp target to run C++ tests for both native and Emscripten platform (+ make build instructions consistent across files) #386
Conversation
mcbarton
force-pushed
the
Make-running-C++-tests-the-check-xeus-cpp-target
branch
2 times, most recently
from
778c098 to
8721b73
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Make-running-C++-tests-the-check-xeus-cpp-target
branch
from
a366271 to
c2b0a28
Compare
|
Just like on my local machine, if I use the node which comes with the emsdk version we are currently using, then it freezes when trying to run the javascript tests. If I use a newer version of node I have installed separately then it runs the tests fine. This also happens with the current version of the build instructions. This PR should be good to go once we move to a newer emsdk version. |
mcbarton
force-pushed
the
Make-running-C++-tests-the-check-xeus-cpp-target
branch
from
c2b0a28 to
8a6273f
Compare
|
So it will run the tests on mac os arm using the old version of node that comes with emsdk 3.1.73 . It just takes 20 minutes on the ci. Locally I always cancelled the node command long before that, and ran the tests using a more recent version where the tests ran immediately. |
Not sure why my change to the ci caused a massive drop in the coverage. Will investigate |
| call C:\Users\runneradmin\micromamba-root\condabin\micromamba.bat activate xeus-cpp | ||
| cd build\test | ||
| .\test_xeus_cpp.exe | ||
| make -j ${{ env.ncpus }} check-xeus-cpp |
There was a problem hiding this comment.
@anutosh491 @vgvassilev I have no idea why I need to install xeus-cpp, before running the tests for the code coverage to not drop, but it does.
|
This PR is ready for review. |
mcbarton
force-pushed
the
Make-running-C++-tests-the-check-xeus-cpp-target
branch
from
72df026 to
e53cd8e
Compare
mcbarton
force-pushed
the
Make-running-C++-tests-the-check-xeus-cpp-target
branch
from
e53cd8e to
632271c
Compare
|
@vgvassilev @anutosh491 pinging for review |
2 participants
Description
Please include a summary of changes, motivation and context for this PR.
This PR makes use of a check-xeus-cpp target to run the C++ tests on both the native and Emscripten platform, and updates the documentation to be consistent across all files (e.g. BUILD_TOOLS_PREFIX vs BUILD_PREFIX)
Fixes # (issue)
Type of change
Please tick all options which are relevant.