This repository was archived by the owner on Sep 29, 2025. It is now read-only.
Fix: Add titles to iframes for accessibility #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
machikoyasuda
changed the title
machikoyasuda
force-pushed
the
feat/180--a11y-iframe
branch
from
83fe228 to
bccd044
Compare
|
This is now ready for review @lalver1 @thekaveman |
lalver1
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Thanks for catching this @machikoyasuda! With this change I no longer see the Use title attribute to describe <iframe> content warning in the Axe-Core DevTools extension 👍
I think the title text is good for now, we'll probably rename the titles as part of #183 but that can happen in a different PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #180
What this PR does
titlewith a human-readable value describing the contents in the <iframe> for allGuidance
titlethat describes the contentWhat to review for