Fix Req Payload Allocation for Transfer FW & Memdev Set LSA #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was found in request payload allocation size for commands with variable data size payloads.
These 2 commits fixes the bug by adding data size as an input parameter.
Previously, the transfer_fw command looked like the below (with added print statements)
When tested with a short test program:
The output was:
This showed that the req_payload size, which should have been the size of the request header + the size of the other fields in the transfer_fw struct + 27, but was instead the size of the request header + 2 * (size of the other fields in the transfer_fw struct).