-
Notifications
You must be signed in to change notification settings - Fork 261
Use CMAKE_TOOLCHAIN_FILE if provided #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop2
Are you sure you want to change the base?
Use CMAKE_TOOLCHAIN_FILE if provided #712
Conversation
use a cmake toolchain file
memsharded
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good, it would be nice to have this covered by one test. Please let us know if you could do it, otherwise we could try to help.
Please note that providing a CMake toolchain file and propagating it to dependencies via the Conan conf will not be enough for dependencies that use other build systems, and there are quite a few of them in ConanCenter. To be able to have dependencies built correctly for those cases, it might still be necessary to provide the necessary information in Conan profile files.
I am passing this to @jcar87 for review.
|
@memsharded I added a test repo. However i'm not familiar with Github Workflows. invoke it with and it should work. i have tested it locally on my windows 11 machine. |
|
hey guys, any further comments on this :) ? |
I have tested this wrapper on cross arm_none_eabi builds with windows.
Turns out it failed because conan was ignoring my toolchain file and letting cmake guess compiler arguments which made my cross arm none eabi build fail.
=> Test if the user has set CMAKE_TOOLCHAIN_FILE via CLI or via preset. If this is set pass this to conan