Skip to content

Conversation

@JulianH1989
Copy link

I have tested this wrapper on cross arm_none_eabi builds with windows.
Turns out it failed because conan was ignoring my toolchain file and letting cmake guess compiler arguments which made my cross arm none eabi build fail.

=> Test if the user has set CMAKE_TOOLCHAIN_FILE via CLI or via preset. If this is set pass this to conan

@CLAassistant
Copy link

CLAassistant commented Nov 5, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, it would be nice to have this covered by one test. Please let us know if you could do it, otherwise we could try to help.

Please note that providing a CMake toolchain file and propagating it to dependencies via the Conan conf will not be enough for dependencies that use other build systems, and there are quite a few of them in ConanCenter. To be able to have dependencies built correctly for those cases, it might still be necessary to provide the necessary information in Conan profile files.

I am passing this to @jcar87 for review.

@JulianH1989
Copy link
Author

@memsharded I added a test repo. However i'm not familiar with Github Workflows.
Could you add the test project to the workflows.

invoke it with

cmake --preset arm_none_eabi_gcc_14_win
cmake --build --preset cmake --preset arm_none_eabi_gcc_14_win_rel

and it should work. i have tested it locally on my windows 11 machine.
There is a linux preset as well which should work

@JulianH1989
Copy link
Author

hey guys, any further comments on this :) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants